Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math and chem code clocks, autoactivation: fix use with hugo version < 0.93 #1351

Merged
merged 1 commit into from Jan 24, 2023

Conversation

deining
Copy link
Collaborator

@deining deining commented Jan 9, 2023

With #1341, autoactivation of math and chem code blocks was fixed. I now realized that as unwanted side effect, the build now breaks with hugo versions < 0.93. This PR corrects this. It also removes the katex from the config file of the use guide. The recommended approach is now to acticate math on a per page basis via math=true in the frontmatter of the page.

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deining
Copy link
Collaborator Author

deining commented Jan 24, 2023

With 2 approvals, I'm going to merge this PR so that it is included in another, related PR that I'm currently preparing. This way, we will avoid merge conflicts later on.

@deining deining merged commit e67205b into google:main Jan 24, 2023
@deining deining deleted the fix-math-chem branch January 24, 2023 11:41
dseynaev pushed a commit to openanalytics/docsy that referenced this pull request Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants