Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BSv5] Script for persisting tabpanes: Fix #1378

Merged
merged 1 commit into from Jan 26, 2023
Merged

[BSv5] Script for persisting tabpanes: Fix #1378

merged 1 commit into from Jan 26, 2023

Conversation

deining
Copy link
Collaborator

@deining deining commented Jan 26, 2023

This PR closes #1377.

@deining deining added bootstrap shortcodes Hugo shortcodes labels Jan 26, 2023
@deining deining requested a review from chalin January 26, 2023 14:38
chalin
chalin approved these changes Jan 26, 2023
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM (will catch up later once I reach the JS section of the migration guide).

@chalin chalin merged commit 1afb4b0 into google:main Jan 26, 2023
@deining deining deleted the issue-1377 branch January 28, 2023 08:20
dseynaev pushed a commit to openanalytics/docsy that referenced this pull request Jan 29, 2023
@deining @dseynaev
[BSv5] Fixes script for persisting tabpanes (google#1378)
f52c960
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
bootstrap shortcodes Hugo shortcodes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BSv5] Script for persisting tabpanes fails
2 participants
@deining @chalin