Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabbed pane, fix: do not print blank first line #1416

Merged
merged 1 commit into from Feb 15, 2023

Conversation

deining
Copy link
Collaborator

@deining deining commented Feb 14, 2023

If the line encoding of the page file with a tabbed pane is CRLF (windows line endings), a blank first line is added in each tab of the tabpane. This PR fixes this issue. This PR also corrects an indentation on the way.

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test it, but LGTM!

@deining
Copy link
Collaborator Author

deining commented Feb 14, 2023

Can't test it

Actually, you can! (even on Linux or MacOS): open userguide/content/en/docs/adding-content/shortcodes/index.md in an editor of your choice, convert line endings to CRLF and run hugo serve. Have a look at the page preview and you will see what I mean.

@deining deining merged commit 64024bd into google:main Feb 15, 2023
@deining deining deleted the tabpane-fix-blank-line branch February 15, 2023 06:42
@deining
Copy link
Collaborator Author

deining commented Feb 15, 2023

Thanks for your approval, merging now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants