Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BSv5] Docsy variables cleanup and BS version test #1462

Merged
merged 1 commit into from Mar 7, 2023

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Mar 7, 2023

  • Checks that BSv5 is being used by a project, otherwise an error is reported by the SASS compiler.
  • Cleans out _variables.scss:
    • Factors out forward declarations of BS SCSS variables into their own file, so that it is clear that they are forward declarations: _variables_forward.scss. Eventually, the content of this file will be auto-generated to avoid definition mismatches.
    • In the process of the refactoring previously mentioned, I dropped unnecessary redeclarations of BS SCSS variables (of the same value).
  • Switches to using the "BSv5-way" of customizing, e.g.,:
    • Now making use of $link-shade-percentage, rather than overriding $link-hover-color
  • Switches to an official BSv5 $blue-* color variable for the link color rather than use a custom adjusted color.
  • Marks some Docsy variable declarations as candidates for namespacing and/or moving into the UG -- I'll open an issue to follow up on this.

@LisaFC
Copy link
Collaborator

LisaFC commented Mar 7, 2023

Looks great!

@chalin chalin merged commit 706dbf9 into google:main Mar 7, 2023
5 checks passed
@chalin chalin deleted the chalin-im-refactor-vars-2023-03-04 branch March 7, 2023 18:45
@chalin
Copy link
Collaborator Author

chalin commented Jul 27, 2023

For the record, this PR introduced an error, that was fixed via:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants