Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Footer, copyright notice: allow customization of year #1593

Merged
merged 1 commit into from Feb 2, 2024
Merged

Footer, copyright notice: allow customization of year #1593

merged 1 commit into from Feb 2, 2024

Conversation

deining
Copy link
Collaborator

@deining deining commented Jun 26, 2023 •
edited by chalin

Following up on #1592, this PR allows to customize the year displayed in the footer's copyright notice. This is done via specifying .Site.Params.copyright.year in your config file.

This PR closes #1592

Closes #2

@deining deining requested a review from chalin June 26, 2023 20:01
@deining deining force-pushed the copyright-year branch 2 times, most recently from 3dbf2e6 to a540ee8 Compare June 27, 2023 20:45
chalin
chalin reviewed Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LisaFC et al.: this was slated for discussion at the PSC but wasn't addressed. I've added it for a topic of discussion at our next meeting. Let's hold on merging this until then.

@chalin
Copy link
Collaborator

chalin commented Jul 27, 2023

Just a note to self that I'll likely want to look at the following first:

@chalin chalin mentioned this pull request Feb 2, 2024
Closed
33 tasks
@chalin
Copy link
Collaborator

chalin commented Feb 2, 2024

PR #1500 has landed. I've proposed a further refactoring via #1817. Once it lands, could you resolve conflicts in this PR?

This was referenced Feb 2, 2024
Closed
Merged
@deining deining force-pushed the copyright-year branch 3 times, most recently from ee064d6 to 8cd349f Compare February 2, 2024 20:37
@deining
Copy link
Collaborator Author

deining commented Feb 2, 2024

All conflicts resolved, checkers are green. This PR is ready for merging now IMHO.

@deining deining requested a review from chalin February 2, 2024 20:50
chalin
chalin approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll follow up with some adjustments in support of #436.

@chalin chalin merged commit 9c3f91b into google:main Feb 2, 2024
11 checks passed
@deining deining deleted the copyright-year branch February 2, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

@yann-soubeyrand yann-soubeyrand yann-soubeyrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copyright year The footer should allow a more flexible copyright statement
3 participants
@deining @chalin @yann-soubeyrand