Make links underlined by default

[froboy]

As per the change upstream in Bootstrap 5 twbs/bootstrap#30389

Removing the underline from links was in vogue for a while, but WebAIM recommends not doing that.

Browsers underline hypertext links by default. It is possible to remove the underline using Cascading Style Sheets (CSS), but this is a bad idea most of the time.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[froboy]

Maybe we just do this for the body? Or we leave the default and override for nav, aside

[froboy]

Ok, sorry for the mess of changes here, and for not opening an issue first, but this is ready for review now. Thanks for your consideration and all of your work.

We're using this in production for the YMCA Website Services documentation at https://ds-docs.y.org/ and it's gotten fantastic feedback.

[chalin]

Thanks for this PR!

Nice website, you might consider submitting a PR to added it to https://www.docsy.dev/docs/examples/?

I agree that having underlines in the body only (as you've done on your website) is probably best. I'll take a closer look soon.

[chalin]

Here's the issue to track this:

• Use Bootstrap's default link style, which is recommended  #1814

Also, I think I have an alternative to propose that will contribute to #1655 at the same time.

[chalin]

Thanks again for this PR, it helped kick this off. A fix has landed, see:

• Link styles: follow recommended practice and underline by default #1815

[froboy]

Thank you! I appreciate your consideration of the issue and I'll get our site submitted to the list of examples. Thanks for your work on Docsy!