Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UG] Explain how to enable the light/dark-mode menu #1914

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Apr 5, 2024

@chalin chalin added the user guide Improvements to user guide label Apr 5, 2024
@chalin chalin requested a review from LisaFC April 5, 2024 19:47
@chalin chalin mentioned this pull request Apr 5, 2024
26 tasks
@chalin chalin force-pushed the chalin-im-dark-mode-docs-2024-04-05 branch from 6c8abb5 to c04c876 Compare April 6, 2024 21:54
@chalin chalin added this to the 24Q2 milestone Apr 6, 2024
@chalin chalin force-pushed the chalin-im-dark-mode-docs-2024-04-05 branch from c04c876 to 0e09609 Compare April 6, 2024 22:34
@chalin chalin force-pushed the chalin-im-dark-mode-docs-2024-04-05 branch 4 times, most recently from a6693a0 to 4c8891e Compare April 7, 2024 22:12
@chalin chalin requested a review from deining April 8, 2024 09:32
Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me.
Added a few comments addressing minor issues.

userguide/content/en/docs/adding-content/lookandfeel.md Outdated Show resolved Hide resolved
userguide/content/en/docs/adding-content/lookandfeel.md Outdated Show resolved Hide resolved
### Light/Dark mode menu

To enable the display of a Light-/[Dark-mode] menu in the navbar, set
`params.ui.showLightDarkModeMenu` to true in your project's configuration file.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

params.ui.showLightDarkModeMenu:

In the section Code highlighting with Prism above, we put a tabbed pane in place, showing toml, yaml and json variants. For the sake of consistency, I would propose to implement the same here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LisaFC et al.: we need to discuss this in the next PSC. I find that for simple boolean params, it isn't worth overhead. If we had something setup like what they have for the Hugo docs, it would make it slightly more bearable! Anyhow, I've made the addition this time.

@chalin chalin force-pushed the chalin-im-dark-mode-docs-2024-04-05 branch from 4c8891e to 358f3c9 Compare April 24, 2024 18:32
@chalin chalin requested a review from deining April 24, 2024 18:32
Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@chalin chalin merged commit 256af85 into google:main Apr 25, 2024
11 checks passed
@chalin chalin deleted the chalin-im-dark-mode-docs-2024-04-05 branch April 25, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user guide Improvements to user guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants