Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of deprecated param .Site.Params.DisqusShortname #1934

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

deining
Copy link
Collaborator

@deining deining commented Apr 17, 2024

This is a follow-up to my merged PR #1895.
It switches to the recommended use of .Site.Config.Services.Disqus.Shortname in two more places.
For background info, see: #1894

@deining deining force-pushed the fix-deprecation-warning-disqus branch from 74ecf02 to 76468f7 Compare April 17, 2024 06:06
@deining deining added this to the 24Q2 milestone Apr 17, 2024
@deining deining mentioned this pull request Apr 17, 2024
21 tasks
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@chalin chalin force-pushed the fix-deprecation-warning-disqus branch from 76468f7 to ce7d4ef Compare April 23, 2024 18:34
@chalin chalin merged commit ec13ca8 into google:main Apr 23, 2024
11 checks passed
@deining deining deleted the fix-deprecation-warning-disqus branch April 23, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants