Fix incorrect use of isset - WIP #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm happy to merge this one now, especially as it fixes an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is my first try to fix #607.
I used
if issetin a wrong way. It's a well disused topic in Hugo (eg gohugoio/hugo#3092) and it's better to use onlyiforwithinstead ofif isset(eg https://discourse.gohugo.io/t/solved-isset-how-to-check-variable-is-empty/1764/5)@LisaFC I'm planning to make some more improvements to the taxonomy support in the next days. Would you like to wait with the merge for them (then a collect all updates in this PR) or should a make separate PRs?