Plantuml svg loader #800
Merged
Plantuml svg loader #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ooh, this looks very helpful. Do you want to also add some instructions to https://www.docsy.dev/docs/adding-content/diagrams-and-formulae/#uml-diagrams-with-plantuml so users will know how to enable this feature? |
|
@LisaFC: A small line perhaps, but is this enough, or would you prefer a more extensive writeup about this? |
|
No, that's perfect! I'm sure someone will let us know if they want more information. |
|
I just realized that this PR sets submodule |
|
No, this was not intended! Did I merge the main branch incorrectly? I don't see anything related to bootstrap in the changed files? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives the possibility to use an SVG loader instead of an using an img tag when using PlantUML. The reason for this is that the image tag does not support links or other responsive actions in the generated UML diagram.
By default, nothing changes. If you want this PR to be enabled, you'll need to change the configuration like this
Setting the params.plantuml.svg property to true will add an additional JavaScript file (svg-loader.min.js), and will write svg tags instead of img tags.