Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: reintroduce explicit call to npm install #859

Merged
merged 1 commit into from
Jan 22, 2022
Merged

CI: reintroduce explicit call to npm install #859

merged 1 commit into from
Jan 22, 2022

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Jan 22, 2022

Reverting the change to netlify.toml as mentioned in #841 (comment).

@chalin chalin added CI/infra CI & infrastructure netlify Tasks for Netlify labels Jan 22, 2022
@chalin
Copy link
Collaborator Author

chalin commented Jan 22, 2022

I'm suspecting that there might be something in the Netlify config that is disabling automatic calls to npm install at the start of a build. Anyhow, this adds an explicit call, which hopefully doesn't happen twice.

@chalin chalin merged commit 2a65214 into google:master Jan 22, 2022
@chalin chalin deleted the chalin-npm-install-2022-01-22 branch January 22, 2022 15:59
@chalin
Copy link
Collaborator Author

chalin commented Jan 22, 2022

Production builds are green once again:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI/infra CI & infrastructure netlify Tasks for Netlify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@chalin