Take td-enable-google-fonts into account for RTL fonts.
#869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
approved these changes
Jan 31, 2022
There was a problem hiding this comment.
Thanks for the PR @SubOptimal.
This seems reasonable to me. Thoughts @LisaFC, @emckean or @theSinner?
|
I'll assume consent and merge now. We can always address any comments in follow PRs. |
|
Fine by me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for the look and feel mention a way to use a system font instead of a Google font.
Currently some of the RTL fonts are always loaded from https://fonts.googleapis.com. It's more consistent, if the variable
td-enable-google-fontscontrols the behavior for all used Google fonts.This PR enables to control the load for RTL fonts from Google or system fonts, similar to the behavior of the primary font "Open Sans".