Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: shortcode 'lead' produces invalid HTML #905

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Fix: shortcode 'lead' produces invalid HTML #905

merged 1 commit into from
Feb 24, 2022

Conversation

deining
Copy link
Collaborator

@deining deining commented Feb 24, 2022

This PR fixes #527.

@deining deining requested a review from chalin February 24, 2022 08:32
@deining
Copy link
Collaborator Author

deining commented Feb 24, 2022

Netlify preview fails at a very early stage, for whatever reason.

chalin
chalin approved these changes Feb 24, 2022
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

(I'm sure that I saw a fix like this before, but I can't track it down.)

@chalin chalin merged commit 1d126ab into google:master Feb 24, 2022
@chalin chalin changed the title Fix: shortcode 'lead' produces invalid HTML (#527) Fix: shortcode 'lead' produces invalid HTML Feb 24, 2022
@chalin
Copy link
Collaborator

chalin commented Feb 24, 2022

Thanks for restarting the build @LisaFC, and thanks for the fix @deining. FYI, I've created followup/related issues:

@deining deining deleted the issue_527 branch February 24, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
cleanup/refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shortcode 'lead' produces invalid HTML
2 participants
@deining @chalin