Add StringToDoubleConverter::StringTo<T> member function templates
#158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-Dekker
force-pushed
the
StringToDoubleConverter-StringTo-template
branch
from
41d3f37
to
71e59bf
Compare
Allowed users to write generic code more easily, like this (when `T` is
either `float` or `double`):
converter.StringTo<T>(buffer, length, &processed);
Included a unit test, `TEST(StringToTemplate)`.
Fixes issue google#157
With help from Florian Loitsch (floitsch)
N-Dekker
force-pushed
the
StringToDoubleConverter-StringTo-template
branch
from
71e59bf
to
6a55772
Compare
|
@floitsch Thanks a lot for merging my very first double-conversion pull request, Florian! You're very helpful! (It's actually my second merged PR at github.com/google, as my PR google/googletest#3184 was merged just last month 😃!) I'm now considering a similar PR for |
N-Dekker
added a commit
to N-Dekker/double-conversion
that referenced
this pull request
Apr 11, 2021
Allowed users to write generic code more easily, in cases where the input value is either a double, or a single-precision float. Included a unit test, `TEST(DoubleToShortestString)`. Complementary to pull request google#158 commit eee1a45 "Add `StringToDoubleConverter::StringTo<T>` member function templates"
N-Dekker
added a commit
to N-Dekker/double-conversion
that referenced
this pull request
Apr 11, 2021
Allowed users to write generic code more easily, in cases where the input value is either a double, or a single-precision float. Included a unit test, `TEST(DoubleToShortestString)`. Complementary to pull request google#158 commit eee1a45 "Add `StringToDoubleConverter::StringTo<T>` member function templates"
7 tasks
N-Dekker
added a commit
to N-Dekker/double-conversion
that referenced
this pull request
Aug 16, 2022
Allowed users to write generic code more easily, in cases where the input value is either a double, or a single-precision float. Included a unit test, `TEST(DoubleToShortestString)`. Complementary to pull request google#158 commit eee1a45 "Add `StringToDoubleConverter::StringTo<T>` member function templates"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowed users to write generic code more easily, like this (when
Tiseither
floatordouble):Included a unit test,
TEST(StringToTemplate).Fixes issue #157
With help from Florian Loitsch (@floitsch)