Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win32: Warning on wrong preprocessor syntax #1031

Closed
ptc-tgamper opened this issue Nov 24, 2023 · 0 comments
Closed

Win32: Warning on wrong preprocessor syntax #1031

ptc-tgamper opened this issue Nov 24, 2023 · 0 comments

Comments

@ptc-tgamper
Copy link
Contributor

When compiling on Win32 with Visual Studio 2019 the following warning is logged by the compiler:
draco\src\draco\io\file_writer_utils.cc(41,28): warning C4067: unexpected tokens following preprocessor directive - expected a newline

Above warning is legit as the preprocessor check
if defined(_WIN32) && not defined(__MINGW32__)
is malformed.

Will post a PR shortly.

ptc-tgamper added a commit to ptc-tgamper/draco that referenced this issue Nov 24, 2023
file_writer_utils.cc - fix preprocessor check and wrong path check
ptc-tgamper added a commit to ptc-tgamper/draco that referenced this issue Nov 24, 2023
file_writer_utils.cc - fix preprocessor check and wrong path check
@ondys ondys closed this as completed in 74a1435 Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant