Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

draco: Improve installation and packaging support. #775

Merged
merged 2 commits into from
Dec 6, 2021
Merged

draco: Improve installation and packaging support. #775

merged 2 commits into from
Dec 6, 2021

Commits on Dec 4, 2021

  1. draco: Improve installation and packaging support. 

    - Fixed omission of draco_version.h when installed in static
  configurations.
- Remove DracoConfig.cmake: it was broken and we actually use
  draco-config.cmake.
- Update FindDraco.cmake so it actually has a chance of working
  properly. Fixed usage of find_path() and subsequent related errors.
- Correct the usage of CMakePackageConfigHelpers in installation target setup
  and the config template.
- Add a CMake version file.
- Normalize the Draco variables exposed in CMake.
  - draco_FOUND -> DRACO_FOUND
  - DRACO_INCLUDE_DIRS, draco_INCLUDE_DIRS -> DRACO_INCLUDE_DIR
  - DRACO_LIBRARIES, draco_LIBRARIES -> DRACO_LIBRARY
  - DRACO_LIBRARY_DIRS, draco_LIBRARY_DIRS -> DRACO_LIBRARY_DIR
  - draco_VERSION_STRING -> DRACO_VERSION
- Use full paths variants of GNUInstallDirs variables to init our
  install paths.

Fixes #764
    @tomfinegan
    tomfinegan committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    1268d12 View commit details
    Browse the repository at this point in the history

  2. Add install() for draco-version.cmake.

    @tomfinegan
    tomfinegan committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    c550f87 View commit details
    Browse the repository at this point in the history