Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create extract-raster-values-for-points tutorial #243

Merged
merged 7 commits into from
Feb 22, 2021

Conversation

swinsem
Copy link
Contributor

@swinsem swinsem commented Oct 20, 2020

Fixed file/dir structure. I also modified some language around points vs. plots and polygons, to make it clear that this would work for polygon plot data as well.
@jdbcode @gino-m

Fixed file/dir structure. I also modified some language around points vs. plots and polygons, to make it clear that this would work for polygon plot data as well.
@google-cla google-cla bot added the cla: yes CLAs approved label Oct 20, 2020
@swinsem swinsem changed the title Create index.md Create extract-raster-values-for-points tutorial Oct 20, 2020
@jdbcode
Copy link
Member

jdbcode commented Oct 21, 2020

Hi @swinsem (Sara), thanks for the pull request! @gino-m and I will be working on the review - expect feedback within a week.

  • Subject and editorial review - @jdbcode
  • Production review for publishing - @gino-m

@jdbcode jdbcode self-assigned this Oct 21, 2020
@swinsem
Copy link
Contributor Author

swinsem commented Oct 28, 2020

Hi @jdbcode , wanted to make sure this worked since there is an error about the Travis CI build that blocked merging when I submitted it last week. I don't know what the error means - is it something I need to correct?

@jdbcode
Copy link
Member

jdbcode commented Oct 28, 2020

RE Travis CI build failure: appears to be failing because there is no period at the end of the tutorial description sentence in the yaml header. It is fine for now. I'll add it to the review comments. I'm starting my review now.

@jdbcode
Copy link
Member

jdbcode commented Nov 14, 2020

Hi @swinsem, I've emailed you about some ideas for making the tutorial a little more modular and including a couple more examples.

swinsem and others added 4 commits January 12, 2021 11:17
This update includes changes recommended by Justin, including a couple new examples, and a section at the end on the pixels included in region reductions and notes on the CRS and scale that are necessary for that process.
@jdbcode
Copy link
Member

jdbcode commented Jan 14, 2021

Hi @swinsem, please see my changes and let me know if you are okay with them or if you'd like to discuss anything.

@swinsem
Copy link
Contributor Author

swinsem commented Jan 14, 2021

@jdbcode it looks great, thanks for the excellent edits!

@jdbcode
Copy link
Member

jdbcode commented Jan 14, 2021

Great!

@gino-m, @swinsem and I have been iterating on this tutorial. We think it is in good shape, but we could you another set of eyes on it. Can you please take a look.

@jdbcode jdbcode assigned gino-m and unassigned jdbcode Jan 14, 2021
@jdbcode
Copy link
Member

jdbcode commented Jan 20, 2021

@swinsem see the changes we discussed. @gino-m, we've identified a topic that needed clarification - there might be a change or two more to settle it.

Made a couple minor changes to clarify wording on weighted reducers.
@jdbcode
Copy link
Member

jdbcode commented Jan 20, 2021

Thanks, @swinsem.

@gino-m, sorry to sneak some extra edits in. All should be good for now. Can you PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLAs approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants