This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Merge 5.3.4.1 to master #1751
Merged
Merge 5.3.4.1 to master #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Test for buffer overflows in Encoder * Throw dbroot errors * Validate key length before encoding * Better error message * Fix crash on decoding error * Remove unnecessary key lenth requirement * Improve unit tests * Test with a short encoding key * Switch to newer "Clone" method in scons * Remove overflow test to avoid adding a dependency * Initial proto dbroot unit tests * Read various dbroot types * Test invalid dbroots * Test with a non-default encoding key
…-to-server-install add apache rotatelogs binary to server install
* Move ReuseOrMakeAndUpdate out of the asset factory * Don't remove assets from the cache unnecessarily * Improved error handling in Storage Manager * Simply asset factory templates and remove unused functions * Move ReuseOrMakeAndUpdate back to the asset factory * Clean up unnecessary namespace references * Improve test coverage
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: don't squash this into a single commit. Use a merge commit.
All commits in this PR were previously included in earthenterprise, so there are no CLA issues or need to thoroughly review the changes.