This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Fix #643: Version Errors With Centos6 #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update with latest PRs.
Update from origin.
tst-dsugar
reviewed
Jan 2, 2018
gitpython support for trusty
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
tst-ccamp
reviewed
Jan 2, 2018
| - sudo apt-get install -qq libperl4-corelibs-perl libtool xorg-dev doxygen python-dev alien swig libgtest-dev libstdc++6 libxml2-dev gettext libxinerama-dev libxft-dev libxrandr-dev libxcursor-dev libgdbm-dev libc6 libc6-dev libmng-dev zlib1g-dev libcap-dev libpng12-0 libpng12-dev freeglut3-dev flex libx11-dev bison++ bisonc++ libjpeg-dev libjpeg8-dev python2.7 python2.7-dev python2.7-psycopg2 libogdi3.2-dev libgif-dev libxerces-c-dev libgeos-dev libgeos++-dev libfreetype6 libfreetype6-dev python-imaging libproj-dev python-setuptools libgif-dev libxerces-c-dev libcap-dev libpq-dev openssl libxml2-utils libxmu-dev | ||
|
|
||
| - sudo apt-get install -qq libperl4-corelibs-perl libtool xorg-dev doxygen python-dev alien swig libgtest-dev libstdc++6 libxml2-dev gettext libxinerama-dev libxft-dev libxrandr-dev libxcursor-dev libgdbm-dev libc6 libc6-dev libmng-dev zlib1g-dev libcap-dev libpng12-0 libpng12-dev freeglut3-dev flex libx11-dev bison++ bisonc++ libjpeg-dev libjpeg8-dev python2.7 python2.7-dev python2.7-psycopg2 libogdi3.2-dev libgif-dev libxerces-c-dev libgeos-dev libgeos++-dev libfreetype6 libfreetype6-dev python-imaging libproj-dev python-setuptools libgif-dev libxerces-c-dev libcap-dev libpq-dev openssl libxml2-utils libxmu-dev python-pip | ||
| - sudo pip install gitpython |
There was a problem hiding this comment.
This has me a bit worried. I've seen some problems with pip in the past, but maybe that was isolated to Apache modules
There was a problem hiding this comment.
In general, if there is a suitable OS Package alternative, then that would be better to use. However, looks like you only use pip for travis ci, so that's probably OK.
tst-jblair
changed the title
tst-jcupp
approved these changes
Jan 3, 2018
tst-ccamp
approved these changes
Jan 4, 2018
husf-dsheremata
added a commit
to husf-dsheremata/earthenterprise
that referenced
this pull request
Jan 6, 2018
Also added xerces-c, ogdi and geos RPM dependencies as they are not always automatically picked up as requirements in the build on all EL6/7 platforms.
tst-lsavoie
pushed a commit
that referenced
this pull request
Jan 8, 2018
…pendencies in rpms (#655) * Added proj rpm dependency to opengee-fusion rpm * #645 - added proj-devel dependency to fix fusion runtime errors. Also added xerces-c, ogdi and geos RPM dependencies as they are not always automatically picked up as requirements in the build on all EL6/7 platforms. * Rearranged rpm dependencies to eliminate circular dependency of opengee-postgist<-->opengee-common rpms. Now opengee-postgis rpm depends on common, and opengee-server and opengee-fusion both explicitly depend on opengee-fusion and opengee-common. * Updated docs with more specific requirements and steps for building and testing RPMs installations. * Removed extraneous dependencies per PR comments, after further testing. * Removed opengee-fusion rpm dependency on opengee-postgis * Added comment explaining why chkconfig is required as an explicit requirement for opengee-common rpm. * Updated version constraint on postgis to support PR #641
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 2.6 doesn't have the same API for Python's subprocess functionality; switch to using the more appropriate and flexible GitPython module instead.
WIP: This change requires GitPython to be added to the installed dependencies.
WIP: If anyone has any ideas for how to immediately get to the root of the git repository tree (required by git.Repo()), I would like a cleaner method for that than "search all parents of the current directory." But, this should just be a minor cleanliness note.
Test Procedure:
Centos 6: Checking that the fix works with Python 2.6.
Centos 7: Checking that the fix works with Python 2.7 (which uses a different version of GitPython, which in turn changes the default setting of an important parameter).