Factor back-end attribute checking into the back end. #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change splits up `front_end/attribute_checker.py`, moving the generic parts to a new file `util/attribute_util.py`, and moving the back-end-specific parts to `back_end/cpp/header_generator.py`. Some tests from `front_end/attribute_checker_test.py` were moved to a new test suite, `header_generator_test.py`. There should probably be a `util/attribute_checker_test.py`, but for now the old tests provide sufficient coverage. As a result of moving some attribute checking into the back end, `generate_header()` can now return errors. A future change should convert some of the `assert` statements in the same file into error returns. In order for the `emboss_codegen_cpp.py` driver to properly display errors, the original source code of the `.emb` is now included verbatim in the IR, increasing the IR size by about 3%. This change does allow attributes from unknown back ends to pass with no checking -- if you put an attribute `[(my_kewl_back_end) i_love_ducks: "ducks are awesome!"]` in an `.emb` file, that will now pass through the compiler without complaint.
|
Would it be useful to the user to include an warning if the backend is unknown? It's not apparent what errors would be presented to the user in this case, especially with future non-c++ codegens. |
|
LGTM |
Fix `traverse_ir_test` by using `varkw` instead of `kwonlyargs`.
I don't have a good solution to this one (and it is the main reason I hadn't moved back end attribute checking into the back end earlier). The two least-bad solutions I've come up with are:
In both cases, the front end would only be able to check that the |
…ack end attributes in the front end.
This change creates the `emboss_library` and `cc_emboss_library` Starlark rules, which mirror `proto_library` and `cc_proto_library`. This also fixes issues with `.emb` files that import `.emb` files that import `.emb` files, where imports-of-imports were not always included in the compilation. This also required new command-line arguments to `emboss_front_end` (`--output-file`) and `emboss_codegen_cpp` (`--input-file` and `--output-file`).
This change splits up `front_end/attribute_checker.py`, moving the generic parts to a new file `util/attribute_util.py`, and moving the back-end-specific parts to `back_end/cpp/header_generator.py`. Some tests from `front_end/attribute_checker_test.py` were moved to a new test suite, `header_generator_test.py`. There should probably be a `util/attribute_checker_test.py`, but for now the old tests provide sufficient coverage. As a result of moving some attribute checking into the back end, `generate_header()` can now return errors. A future change should convert some of the `assert` statements in the same file into error returns. In order for the `emboss_codegen_cpp.py` driver to properly display errors, the original source code of the `.emb` is now included verbatim in the IR, increasing the IR size by about 3%. This change does allow attributes from unknown back ends to pass with no checking -- if you put an attribute `[(my_kewl_back_end) i_love_ducks: "ducks are awesome!"]` in an `.emb` file, that will now pass through the compiler without complaint.
This change splits up `front_end/attribute_checker.py`, moving the generic parts to a new file `util/attribute_util.py`, and moving the back-end-specific parts to `back_end/cpp/header_generator.py`. Some tests from `front_end/attribute_checker_test.py` were moved to a new test suite, `header_generator_test.py`. There should probably be a `util/attribute_checker_test.py`, but for now the old tests provide sufficient coverage. As a result of moving some attribute checking into the back end, `generate_header()` can now return errors. A future change should convert some of the `assert` statements in the same file into error returns. In order for the `emboss_codegen_cpp.py` driver to properly display errors, the original source code of the `.emb` is now included verbatim in the IR, increasing the IR size by about 3%. This change does allow attributes from unknown back ends to pass with no checking -- if you put an attribute `[(my_kewl_back_end) i_love_ducks: "ducks are awesome!"]` in an `.emb` file, that will now pass through the compiler without complaint.
…ack end attributes in the front end.
This change splits up `front_end/attribute_checker.py`, moving the generic parts to a new file `util/attribute_util.py`, and moving the back-end-specific parts to `back_end/cpp/header_generator.py`. Some tests from `front_end/attribute_checker_test.py` were moved to a new test suite, `header_generator_test.py`. There should probably be a `util/attribute_checker_test.py`, but for now the old tests provide sufficient coverage. As a result of moving some attribute checking into the back end, `generate_header()` can now return errors. A future change should convert some of the `assert` statements in the same file into error returns. In order for the `emboss_codegen_cpp.py` driver to properly display errors, the original source code of the `.emb` is now included verbatim in the IR, increasing the IR size by about 3%. This change does allow attributes from unknown back ends to pass with no checking -- if you put an attribute `[(my_kewl_back_end) i_love_ducks: "ducks are awesome!"]` in an `.emb` file, that will now pass through the compiler without complaint.
This change splits up `front_end/attribute_checker.py`, moving the generic parts to a new file `util/attribute_util.py`, and moving the back-end-specific parts to `back_end/cpp/header_generator.py`. Some tests from `front_end/attribute_checker_test.py` were moved to a new test suite, `header_generator_test.py`. There should probably be a `util/attribute_checker_test.py`, but for now the old tests provide sufficient coverage. As a result of moving some attribute checking into the back end, `generate_header()` can now return errors. A future change should convert some of the `assert` statements in the same file into error returns. In order for the `emboss_codegen_cpp.py` driver to properly display errors, the original source code of the `.emb` is now included verbatim in the IR, increasing the IR size by about 3%. This change does still enforce some minimal checking of back end attributes: the back end must be listed in the new `[expected_back_ends]` attribute (default value `"cpp"`), or they are considered to be an error. This change does not document the `[expected_back_ends]` attribute because it is not currently useful for end users.
…tlov/emboss into extract_attribute_checking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change splits up
front_end/attribute_checker.py, moving the generic parts to a new fileutil/attribute_util.py, and moving the back-end-specific parts toback_end/cpp/header_generator.py.Some tests from
front_end/attribute_checker_test.pywere moved to a new test suite,header_generator_test.py. There should probably be autil/attribute_checker_test.py, but for now the old tests provide sufficient coverage.As a result of moving some attribute checking into the back end,
generate_header()can now return errors. A future change should convert some of theassertstatements in the same file into error returns.In order for the
emboss_codegen_cpp.pydriver to properly display errors, the original source code of the.embis now included verbatim in the IR, increasing the IR size by about 3%.This change does allow attributes from unknown back ends to pass with no checking -- if you put an attribute
[(my_kewl_back_end) i_love_ducks: "ducks are awesome!"]in an.embfile, that will now pass through the compiler without complaint.