read protected message fails on reading gnupg signed ascii armored message

[koto]

From se...@zagrodzki.net on June 04, 2014 01:24:42

Steps to reproduce:

1. open prompt.html, read a protected message
   2.
   -----BEGIN PGP MESSAGE-----
   Version: GnuPG v1.4.11 (GNU/Linux)

owEBOwLE/ZANAwAIAUIGW1QB70MdAcsLYgBTjlghdGVzdAqJAhwEAAEIAAYFAlOO
WCEACgkQQgZbVAHvQx2GvBAAysBVNufueZW0ixqqQk7BbJy7/enrOpMH4ttaZMhm
7rkxG0PgFVUokuV+8gyijRXxg/nMhoz8M9pOyYBhpFyMVEUZSSRWGkt9Xg3cQJB2
jd6JojZopPQHPPOd/6pSByrFZEkvDvciDUCdlvt/Uxr6o9oYHNglzuX5jilJ7l+y
mNIa3l4Okr2DdJu8wOpqhah/Gev3T51GVkpxligYtk/mJm4pswsBOTlcOwQEqg6u
2xTuFU3q8BizH/oTGuT0mmSJbSy9d64nYhwPjQBpUz9fsTK8+MaPy0aAQ3jIOtmj
IZs6G0w20vLVzAkKI3brP/68oZ7Im4IRWqzHWG3wAkUrnmHDMlJyoviz7LmI2AVg
XZ5t3aq88oCJMIyMuu55qIxqsDwhlcpGE7nbVjvj62rODKhMp3FNPNjH234wS7iN
TNlxDKXDTHb34gxJ5QFesZ3+OfsTUvS5KtV/bizB+UBTnswWRDNBmwJyT2zvOqc2
TPhlfBzdobSKAbJ13aTC55SrADy1VMIPzam5mnX9tfhWvsf2ARBzsOSSCiYjE4xk
e7DRT5v9vaJKrXBReClUq1/9D0ZR0KdDV0bWfCplV18ecOzhL6PUFgHX6SlHjlOV
qvYGYiuG8xLR8S4ncS0MBaI3jcL/oUTsQ+43oP3+8Go7C3N/j7pIV6J7urnzKwIz
zdc=
=T2iD
-----END PGP MESSAGE-----

3. press "Read"

What happens?
"Cannot read property 'length' of undefined" error pops up

What do you expect to happen instead?
I expect the message to be decoded and verified.

Original issue: http://code.google.com/p/end-to-end/issues/detail?id=7

[koto]

From se...@zagrodzki.net on June 03, 2014 16:28:32

FTR, this is a signed ascii-armored message with no encryption. Message with signature and encryption works as expected, although signature is not verified in an apparent way, popup mentions only "decryption successful".

[koto]

From evn@google.com on June 03, 2014 16:54:34

interesting. looking into it

[koto]

From evn@google.com on June 03, 2014 17:02:50

Yup, this is true. Never seen someone using ascii-armored non-encrypted messages, but the RFC seems to allow it.

Status: Accepted

[koto]

From evn@google.com on June 03, 2014 17:03:14

would you mind if we use your message as a unit test?

[koto]

From rickyorb...@gmail.com on June 03, 2014 17:55:01

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA224

I also experience this, use my message as a test unit.
-----BEGIN PGP SIGNATURE-----
Charset: UTF-8
Version: End-To-End v0.3.1337

wv8AAAEkBAEBCwAY/wAAAAWCU45uWv8AAAAJkErdCuNp2cK4AAAVFQf/YFWZLw6K
aZXt4aP6J/5FQoTgHOJMh3PvhfG2OVS8Dmo0GMFohG5BnzYwYv8TzbN798Ss0pPG
/emAJGjAXgG0gvzCRWR15oTvk6Lg8qzcfF6ww3hQNBmr5hfaq6a4tMhsxb++/dyA
fph7OhROY17Ow+1+vbhhe+M0CLZ4M3Q54AKiOsJwsa9zrtpi0UrK8tqSnWYhexFx
p2uOrImR184B+PLMZvmvkkH9nZeUDAOzVb49aP2iZQCqJ//f4yVapTngedmuy3D9
qYN/qWg3hkeeZS3FMU+XU2bGVMhxNW63d0WYlSYdJ9O1NfwrU+vzgdi0a8l1OL50
zd74U9P6BBiv5Q==
=p6b1
-----END PGP SIGNATURE-----

[koto]

From rickyorb...@gmail.com on June 03, 2014 17:56:03

Sorry, I should read the entire thread before posting, I was trying to verify signatures through that same UI. Please ignore the above message.

[koto]

From se...@google.com on June 04, 2014 04:39:13

Sure, feel free to use it in a unit test.

[koto]

From evn@google.com on June 04, 2014 07:32:46

Thanks, I ended up refactoring a little bit how we handle encrypted blocks.

I'll update this bug when we have a patch.

Status: Started

[koto]

From evn@google.com on June 06, 2014 18:21:41

Labels: Type-Defect Priority-Medium Component-Logic Compatibility

[koto]

From evn@google.com on June 07, 2014 12:11:42

Status: FixedInStaging

[koto]

From evn@google.com on June 16, 2014 03:50:49

To avoid us loosing track of responses to closed bugs, restrict adding comments to closed issues.

Please file a new bug if needed.

Labels: Restrict-AddIssueComment-CoreTeam

[koto]

From evn@google.com on June 25, 2014 12:00:36

Pushed https://code.google.com/p/end-to-end/source/detail?r=b6a0b9b8cde9c446f42bc81d4bd7d394996e10b7

Status: Fixed