Add more test cases for SelfEquals

MOE_MIGRATED_REVID=130441140
google · Aug 17, 2016 · 30d408d · 30d408d
1 parent 4587aea
commit 30d408d
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 4 deletions.
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SelfEqualsNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SelfEqualsNegativeCases.java
@@ -16,8 +16,13 @@
 
 package com.google.errorprone.bugpatterns.testdata;
 
+import static com.google.common.truth.Truth.assertThat;
+
 /**
+ * Negative test cases for {@link SelfEquals} check.
+ *
  * @author alexeagle@google.com (Alex Eagle)
+ * @author bhagwani@google.com (Sumit Bhagwani)
  */
 public class SelfEqualsNegativeCases {
   private String field;
@@ -26,18 +31,26 @@ public class SelfEqualsNegativeCases {
   public int hashCode() {
     return field != null ? field.hashCode() : 0;
   }
-  
+
   @Override
   public boolean equals(Object o) {
     if (!(o instanceof SelfEqualsNegativeCases)) {
       return false;
     }
-    
+
     SelfEqualsNegativeCases other = (SelfEqualsNegativeCases) o;
     return field.equals(other.field);
   }
-  
+
   public boolean test() {
     return Boolean.TRUE.toString().equals(Boolean.FALSE.toString());
   }
+
+  public void testAssertThatEq(SelfEqualsNegativeCases obj) {
+    assertThat(obj).isEqualTo(obj);
+  }
+
+  public void testAssertThatNeq(SelfEqualsNegativeCases obj) {
+    assertThat(obj).isNotEqualTo(obj);
+  }
 }
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SelfEqualsPositiveCase.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SelfEqualsPositiveCase.java
@@ -16,8 +16,13 @@
 
 package com.google.errorprone.bugpatterns.testdata;
 
+import org.junit.Assert;
+
 /**
+ * Positive test cases for {@link SelfEquals} check.
+ *
  * @author eaftan@google.com (Eddie Aftandilian)
+ * @author bhagwani@google.com (Sumit Bhagwani)
  */
 public class SelfEqualsPositiveCase {
   private String simpleField;
@@ -66,7 +71,12 @@ public boolean test5(SelfEqualsPositiveCase obj) {
     // BUG: Diagnostic contains: An object is tested for equality to itself
     return equals(this);
   }
-
+
+  public void testAssertTrue(SelfEqualsPositiveCase obj) {
+    // BUG: Diagnostic contains: An object is tested for equality to itself
+    Assert.assertTrue(obj.equals(obj));
+  }
+
   @Override
   public boolean equals(Object obj) {
     if (obj == null || getClass() != obj.getClass()) {