Skip to content

Commit

Permalink
Remove javax.inject from installation instructions
Browse files Browse the repository at this point in the history
The dependecy is included as of 2.23.0

#3897
  • Loading branch information
cushon committed Oct 29, 2023
1 parent 2b52c4a commit 373d9e3
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions docs/installation.md
Expand Up @@ -126,15 +126,13 @@ Download the following artifacts from maven:
[https://repo1.maven.org/maven2/com/google/errorprone/error_prone_core/](https://repo1.maven.org/maven2/com/google/errorprone/error_prone_core/)
* `dataflow-errorprone-${DATAFLOW_VERSION?}.jar` from
[https://repo1.maven.org/maven2/io/github/eisop/dataflow-errorprone/](https://repo1.maven.org/maven2/io/github/eisop/dataflow-errorprone/)
* [`https://repo1.maven.org/maven2/javax/inject/javax.inject/1/javax.inject-1.jar`](https://repo1.maven.org/maven2/javax/inject/javax.inject/1/javax.inject-1.jar)

and add the following javac task to your project's `build.xml` file:

```xml
<path id="processorpath.ref">
<pathelement location="${user.home}/.m2/repository/com/google/errorprone/error_prone_core/${error-prone.version}/error_prone_core-${error-prone.version}-with-dependencies.jar"/>
<pathelement location="${user.home}/.m2/repository/io/github/eisop/dataflow-errorprone/${dataflow.version}/dataflow-errorprone-${dataflow.version}.jar"/>
<pathelement location="${user.home}/.m2/repository/javax/inject/javax.inject/1/javax.inject-1.jar"/>
</path>

<javac srcdir="src" destdir="build" fork="yes" includeantruntime="no">
Expand Down Expand Up @@ -192,7 +190,6 @@ Example:
```bash
wget https://repo1.maven.org/maven2/com/google/errorprone/error_prone_core/${EP_VERSION?}/error_prone_core-${EP_VERSION?}-with-dependencies.jar
wget https://repo1.maven.org/maven2/io/github/eisop/dataflow-errorprone/${DATAFLOW_VERSION?}/dataflow-errorprone-${DATAFLOW_VERSION?}.jar
wget https://repo1.maven.org/maven2/javax/inject/javax.inject/1/javax.inject-1.jar
javac \
-J--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED \
-J--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED \
Expand All @@ -205,7 +202,7 @@ javac \
-J--add-opens=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED \
-J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED \
-XDcompilePolicy=simple \
-processorpath error_prone_core-${EP_VERSION?}-with-dependencies.jar:dataflow-errorprone-${DATAFLOW_VERSION?}.jar:javax.inject-1.jar \
-processorpath error_prone_core-${EP_VERSION?}-with-dependencies.jar:dataflow-errorprone-${DATAFLOW_VERSION?}.jar \
'-Xplugin:ErrorProne -XepDisableAllChecks -Xep:CollectionIncompatibleType:ERROR' \
ShortSet.java
```
Expand Down

0 comments on commit 373d9e3

Please sign in to comment.