Suppress FieldCanBeLocal based on unused prefices.

PiperOrigin-RevId: 496985585
google · Dec 21, 2022 · 4a5fd7b · 4a5fd7b
1 parent fd1748d
commit 4a5fd7b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/FieldCanBeLocal.java b/core/src/main/java/com/google/errorprone/bugpatterns/FieldCanBeLocal.java
@@ -86,7 +86,8 @@ public Void visitVariable(VariableTree variableTree, Void unused) {
         if (symbol.getKind() == ElementKind.FIELD
             && symbol.isPrivate()
             && canBeLocal(variableTree)
-            && !shouldKeep(variableTree)) {
+            && !shouldKeep(variableTree)
+            && !symbol.getSimpleName().toString().startsWith("unused")) {
           potentialFields.put(symbol, getCurrentPath());
         }
         return null;

diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/FieldCanBeLocalTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/FieldCanBeLocalTest.java
@@ -48,6 +48,21 @@ public void simplePositive() {
         .doTest();
   }
 
+  @Test
+  public void suppressedByUnusedPrefix() {
+    helper
+        .addSourceLines(
+            "Test.java",
+            "class Test {",
+            "  private int unusedA;",
+            "  int foo() {",
+            "    unusedA = 1;",
+            "    return unusedA;",
+            "  }",
+            "}")
+        .doTest();
+  }
+
   @Test
   public void multipleAssignments() {
     refactoringTestHelper