Audit EP checks for argumentless mock().

DoNotMock is the only one that uses the arg, so I added a test and handled it. DirectInvocationOnMockTest was sorta implicitly using it, in that it only wanted the one-arg version to exclude stubs with arguments. PiperOrigin-RevId: 493418603
google · Dec 14, 2022 · 501b455 · 501b455
1 parent f9aa11e
commit 501b455
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 9 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/AbstractMockChecker.java b/core/src/main/java/com/google/errorprone/bugpatterns/AbstractMockChecker.java
@@ -168,10 +168,13 @@ public static <T extends Tree> TypeExtractor<T> extractType(Matcher<T> m) {
   public static TypeExtractor<MethodInvocationTree> extractFirstArg(
       Matcher<MethodInvocationTree> m) {
     return (tree, state) -> {
-      if (m.matches(tree, state)) {
+      if (!m.matches(tree, state)) {
+        return Optional.empty();
+      }
+      if (tree.getArguments().size() >= 1) {
         return Optional.ofNullable(ASTHelpers.getType(tree.getArguments().get(0)));
       }
-      return Optional.empty();
+      return Optional.ofNullable(ASTHelpers.targetType(state)).map(t -> t.type());
     };
   }
 

diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/DirectInvocationOnMock.java b/core/src/main/java/com/google/errorprone/bugpatterns/DirectInvocationOnMock.java
@@ -22,6 +22,7 @@
 import static com.google.errorprone.matchers.Description.NO_MATCH;
 import static com.google.errorprone.matchers.Matchers.allOf;
 import static com.google.errorprone.matchers.Matchers.anyMethod;
+import static com.google.errorprone.matchers.Matchers.anyOf;
 import static com.google.errorprone.matchers.Matchers.instanceMethod;
 import static com.google.errorprone.matchers.Matchers.receiverOfInvocation;
 import static com.google.errorprone.matchers.Matchers.staticMethod;
@@ -167,7 +168,12 @@ public Void visitAssignment(AssignmentTree tree, Void unused) {
   }
 
   private static final Matcher<ExpressionTree> MOCK =
-      staticMethod().onClass("org.mockito.Mockito").named("mock").withParameters("java.lang.Class");
+      anyOf(
+          staticMethod()
+              .onClass("org.mockito.Mockito")
+              .named("mock")
+              .withParameters("java.lang.Class"),
+          staticMethod().onClass("org.mockito.Mockito").named("mock").withNoParameters());
 
   private static final Matcher<MethodInvocationTree> DO_CALL_REAL_METHOD =
       allOf(

diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/MockNotUsedInProduction.java b/core/src/main/java/com/google/errorprone/bugpatterns/MockNotUsedInProduction.java
@@ -180,12 +180,7 @@ private boolean annotatedAtMostMock(Symbol symbol) {
   }
 
   private static final Matcher<ExpressionTree> MOCK =
-      anyOf(
-          staticMethod()
-              .onClass("org.mockito.Mockito")
-              .namedAnyOf("mock")
-              .withParameters("java.lang.Class"),
-          staticMethod().onClass("org.mockito.Mockito").namedAnyOf("spy"));
+      staticMethod().onClass("org.mockito.Mockito").namedAnyOf("mock", "spy");
 
   private static final Matcher<VariableTree> MOCK_OR_SPY_ANNOTATED =
       anyOf(hasAnnotation("org.mockito.Mock"), hasAnnotation("org.mockito.Spy"));

diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/DirectInvocationOnMockTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/DirectInvocationOnMockTest.java
@@ -47,6 +47,22 @@ public void directInvocationOnMock() {
         .doTest();
   }
 
+  @Test
+  public void directInvocationOnMock_createdUsingArgumentlessMock() {
+    helper
+        .addSourceLines(
+            "Test.java",
+            "import static org.mockito.Mockito.mock;",
+            "class Test {",
+            "  public void test() {",
+            "    Test test = mock();",
+            "    // BUG: Diagnostic contains: test",
+            "    test.test();",
+            "  }",
+            "}")
+        .doTest();
+  }
+
   @Test
   public void directInvocationOnMockAssignment() {
     helper