Fix a crash in UnnecessaryStringBuilder

Fixes external #4195 PiperOrigin-RevId: 601777043
google · Jan 26, 2024 · 7d1ae83 · 7d1ae83
1 parent 417b935
commit 7d1ae83
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/UnnecessaryStringBuilder.java b/core/src/main/java/com/google/errorprone/bugpatterns/UnnecessaryStringBuilder.java
@@ -117,6 +117,9 @@ public Description matchNewClass(NewClassTree tree, VisitorState state) {
       }
     }
     ASTHelpers.TargetType target = ASTHelpers.targetType(state.withPath(path));
+    if (target == null) {
+      return NO_MATCH;
+    }
     if (!isUsedAsStringBuilder(state, target)) {
       return describeMatch(
           path.getLeaf(), SuggestedFix.replace(path.getLeaf(), replacement(state, parts)));

diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/UnnecessaryStringBuilderTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/UnnecessaryStringBuilderTest.java
@@ -164,4 +164,17 @@ public void varType() {
             "}")
         .doTest();
   }
+
+  @Test
+  public void unusedReturnValue() {
+    testHelper
+        .addSourceLines(
+            "Test.java",
+            "class Test {",
+            "  void f() {",
+            "    new StringBuilder().append(\"foo\");",
+            "  }",
+            "}")
+        .doTest();
+  }
 }