Avoid CreateProcess error=206 on Windows

Make sure command lines involving many files get placed in a temp file to avoid overflowing the command buffer
google · Jun 25, 2015 · 8bdc63d · 8bdc63d
1 parent 5f29fe6
commit 8bdc63d
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/ant/src/main/java/com/google/errorprone/ErrorProneExternalCompilerAdapter.java b/ant/src/main/java/com/google/errorprone/ErrorProneExternalCompilerAdapter.java
@@ -101,8 +101,9 @@ public boolean execute() throws BuildException {
       cmd.createArgument().setPath(classpath);
       cmd.createArgument().setValue(ErrorProneCompiler.class.getName());
       setupModernJavacCommandlineSwitches(cmd);
+      int firstFile = cmd.size();
       logAndAddFilesToCompile(cmd);
-      return executeExternalCompile(cmd.getCommandline(), cmd.size(), true) == 0;
+      return executeExternalCompile(cmd.getCommandline(), firstFile, true) == 0;
     } else {
       attributes.log("You must set fork=\"yes\" to use the external error-prone compiler",
           Project.MSG_ERR);