Remove CompilationTestHelper.newInstance(BugChecker, Class<?>)

It's misleading, because it doesn't allow per-instance state to be propagated
through: we call getClass() and then drop the instance that's passed in.

RELNOTES: N/A
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=92514999

core/src/test/java/com/google/errorprone/CompilationTestHelper.java

@@ -80,19 +80,6 @@ public static CompilationTestHelper newInstance(ScannerSupplier scannerSupplier,
     return new CompilationTestHelper(scannerSupplier, null, clazz);
   }
 
-  /**
-   * Returns a new {@link CompilationTestHelper}.
-   *
-   * @param checker the {@link BugChecker} to test
-   * @param clazz the class to use to locate file resources
-   */
-  // TODO(user): deprecate and migrate to newInstance(Class<? extends BugChecker>, Class<?>)
-  // This version is misleading, because it doesn't allow per-instance state to be propagated
-  // through: we call getClass() and then drop the instance that's passed in.
-  public static CompilationTestHelper newInstance(BugChecker checker, Class<?> clazz) {
-    return newInstance(checker.getClass(), clazz);
-  }
-
   /**
    * Returns a new {@link CompilationTestHelper}.
    *

core/src/test/java/com/google/errorprone/CompilationTestHelperTest.java

@@ -45,7 +45,7 @@ public class CompilationTestHelperTest {
 
   @Before
   public void setUp() {
-    compilationHelper = CompilationTestHelper.newInstance(new ReturnTreeChecker(), getClass());
+    compilationHelper = CompilationTestHelper.newInstance(ReturnTreeChecker.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/ArrayEqualsTest.java

@@ -36,7 +36,7 @@ public class ArrayEqualsTest {
 
   @Before
   public void setUp() {
-    compilationHelper = CompilationTestHelper.newInstance(new ArrayEquals(), getClass());
+    compilationHelper = CompilationTestHelper.newInstance(ArrayEquals.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/ArrayHashCodeTest.java

@@ -36,7 +36,7 @@ public class ArrayHashCodeTest {
 
   @Before
   public void setUp() {
-    compilationHelper = CompilationTestHelper.newInstance(new ArrayHashCode(), getClass());
+    compilationHelper = CompilationTestHelper.newInstance(ArrayHashCode.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/ArrayToStringCompoundAssignmentTest.java

@@ -34,7 +34,7 @@ public class ArrayToStringCompoundAssignmentTest {
   @Before
   public void setUp() {
     compilationHelper =
-        CompilationTestHelper.newInstance(new ArrayToStringCompoundAssignment(), getClass());
+        CompilationTestHelper.newInstance(ArrayToStringCompoundAssignment.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/ArrayToStringConcatenationTest.java

@@ -34,7 +34,7 @@ public class ArrayToStringConcatenationTest {
   @Before
   public void setUp() {
     compilationHelper =
-        CompilationTestHelper.newInstance(new ArrayToStringConcatenation(), getClass());
+        CompilationTestHelper.newInstance(ArrayToStringConcatenation.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/ArrayToStringTest.java

@@ -33,7 +33,7 @@ public class ArrayToStringTest {
 
   @Before
   public void setUp() {
-    compilationHelper = CompilationTestHelper.newInstance(new ArrayToString(), getClass());
+    compilationHelper = CompilationTestHelper.newInstance(ArrayToString.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/AssertFalseTest.java

@@ -33,7 +33,7 @@ public class AssertFalseTest {
 
   @Before
   public void setUp() {
-    compilationHelper = CompilationTestHelper.newInstance(new AssertFalse(), getClass());
+    compilationHelper = CompilationTestHelper.newInstance(AssertFalse.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/AsyncFunctionReturnsNullTest.java

@@ -33,7 +33,7 @@ public class AsyncFunctionReturnsNullTest {
   @Before
   public void setUp() {
     compilationHelper =
-        CompilationTestHelper.newInstance(new AsyncFunctionReturnsNull(), getClass());
+        CompilationTestHelper.newInstance(AsyncFunctionReturnsNull.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/BadShiftAmountTest.java

@@ -33,7 +33,7 @@ public class BadShiftAmountTest {
 
   @Before
   public void setUp() {
-    compilationHelper = CompilationTestHelper.newInstance(new BadShiftAmount(), getClass());
+    compilationHelper = CompilationTestHelper.newInstance(BadShiftAmount.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/CannotMockFinalClassTest.java

@@ -43,7 +43,7 @@ public class CannotMockFinalClassTest {
 
   @Before
   public void setUp() {
-    compilationHelper = CompilationTestHelper.newInstance(new CannotMockFinalClass(), getClass());
+    compilationHelper = CompilationTestHelper.newInstance(CannotMockFinalClass.class, getClass());
   }
 
   static final class FinalClass {

core/src/test/java/com/google/errorprone/bugpatterns/ChainingConstructorIgnoresParameterTest.java

@@ -33,7 +33,7 @@ public class ChainingConstructorIgnoresParameterTest {
   @Before
   public void setUp() {
     compilationHelper =
-        CompilationTestHelper.newInstance(new ChainingConstructorIgnoresParameter(), getClass());
+        CompilationTestHelper.newInstance(ChainingConstructorIgnoresParameter.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/CheckReturnValueTest.java

@@ -33,7 +33,7 @@ public class CheckReturnValueTest {
 
   @Before
   public void setUp() {
-    compilationHelper = CompilationTestHelper.newInstance(new CheckReturnValue(), getClass());
+    compilationHelper = CompilationTestHelper.newInstance(CheckReturnValue.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/ClassCanBeStaticTest.java

@@ -33,7 +33,7 @@ public class ClassCanBeStaticTest {
 
   @Before
   public void setUp() {
-    compilationHelper = CompilationTestHelper.newInstance(new ClassCanBeStatic(), getClass());
+    compilationHelper = CompilationTestHelper.newInstance(ClassCanBeStatic.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/ClassNameTest.java

@@ -31,7 +31,7 @@ public class ClassNameTest {
 
   @Before
   public void setUp() {
-    compilationHelper = CompilationTestHelper.newInstance(new ClassName(), getClass());
+    compilationHelper = CompilationTestHelper.newInstance(ClassName.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/CollectionIncompatibleTypeTest.java

@@ -34,7 +34,7 @@ public class CollectionIncompatibleTypeTest {
   @Before
   public void setUp() {
     compilationHelper =
-        CompilationTestHelper.newInstance(new CollectionIncompatibleType(), getClass());
+        CompilationTestHelper.newInstance(CollectionIncompatibleType.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/ComparisonOutOfRangeTest.java

@@ -33,7 +33,7 @@ public class ComparisonOutOfRangeTest {
 
   @Before
   public void setUp() {
-    compilationHelper = CompilationTestHelper.newInstance(new ComparisonOutOfRange(), getClass());
+    compilationHelper = CompilationTestHelper.newInstance(ComparisonOutOfRange.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/CompileTimeConstantCheckerTest.java

@@ -36,7 +36,7 @@ public class CompileTimeConstantCheckerTest {
   @Before
   public void setUp() {
     compilationHelper =
-        CompilationTestHelper.newInstance(new CompileTimeConstantChecker(), getClass());
+        CompilationTestHelper.newInstance(CompileTimeConstantChecker.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/CovariantEqualsTest.java

@@ -33,7 +33,7 @@ public class CovariantEqualsTest {
 
   @Before
   public void setUp() {
-    compilationHelper = CompilationTestHelper.newInstance(new CovariantEquals(), getClass());
+    compilationHelper = CompilationTestHelper.newInstance(CovariantEquals.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/DeadExceptionTest.java

@@ -33,7 +33,7 @@ public class DeadExceptionTest {
 
   @Before
   public void setUp() {
-    compilationHelper = CompilationTestHelper.newInstance(new DeadException(), getClass());
+    compilationHelper = CompilationTestHelper.newInstance(DeadException.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/DepAnnTest.java

@@ -32,7 +32,7 @@ public class DepAnnTest {
 
   @Before
   public void setUp() {
-    compilationHelper = CompilationTestHelper.newInstance(new DepAnn(), getClass());
+    compilationHelper = CompilationTestHelper.newInstance(DepAnn.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/DivZeroTest.java

@@ -33,7 +33,7 @@ public class DivZeroTest {
 
   @Before
   public void setUp() {
-    compilationHelper = CompilationTestHelper.newInstance(new DivZero(), getClass());
+    compilationHelper = CompilationTestHelper.newInstance(DivZero.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/ElementsCountedInLoopTest.java

@@ -34,7 +34,7 @@ public class ElementsCountedInLoopTest {
 
   @Before
   public void setUp() {
-    compilationHelper = CompilationTestHelper.newInstance(new ElementsCountedInLoop(), getClass());
+    compilationHelper = CompilationTestHelper.newInstance(ElementsCountedInLoop.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/EmptyIfStatementTest.java

@@ -33,7 +33,7 @@ public class EmptyIfStatementTest {
 
   @Before
   public void setUp() {
-    compilationHelper = CompilationTestHelper.newInstance(new EmptyIfStatement(), getClass());
+    compilationHelper = CompilationTestHelper.newInstance(EmptyIfStatement.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/EqualsHashCodeTest.java

@@ -30,7 +30,7 @@ public class EqualsHashCodeTest {
 
   @Before
   public void setUp() {
-    compilationHelper = CompilationTestHelper.newInstance(new EqualsHashCode(), getClass());
+    compilationHelper = CompilationTestHelper.newInstance(EqualsHashCode.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/EqualsNaNTest.java

@@ -33,7 +33,7 @@ public class EqualsNaNTest {
 
   @Before
   public void setUp() {
-    compilationHelper = CompilationTestHelper.newInstance(new EqualsNaN(), getClass());
+    compilationHelper = CompilationTestHelper.newInstance(EqualsNaN.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/FinallyTest.java

@@ -33,7 +33,7 @@ public class FinallyTest {
 
   @Before
   public void setUp() {
-    compilationHelper = CompilationTestHelper.newInstance(new Finally(), getClass());
+    compilationHelper = CompilationTestHelper.newInstance(Finally.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/ForOverrideCheckerTest.java

@@ -34,7 +34,7 @@ public class ForOverrideCheckerTest {
   @Before
   public void setUp() throws Exception {
     compilationHelper = CompilationTestHelper
-        .newInstance(new ForOverrideChecker(), getClass())
+        .newInstance(ForOverrideChecker.class, getClass())
         .addSourceLines(
             "test/ExtendMe.java",
             "package test;",

core/src/test/java/com/google/errorprone/bugpatterns/GuiceAssistedInjectScopingTest.java

@@ -34,7 +34,7 @@ public class GuiceAssistedInjectScopingTest {
   @Before
   public void setUp() {
     compilationHelper =
-        CompilationTestHelper.newInstance(new GuiceAssistedInjectScoping(), getClass());
+        CompilationTestHelper.newInstance(GuiceAssistedInjectScoping.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/GuiceAssistedParametersTest.java

@@ -34,7 +34,7 @@ public class GuiceAssistedParametersTest {
   @Before
   public void setUp() {
     compilationHelper =
-        CompilationTestHelper.newInstance(new GuiceAssistedParameters(), getClass());
+        CompilationTestHelper.newInstance(GuiceAssistedParameters.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/GuiceInjectOnFinalFieldTest.java

@@ -33,7 +33,7 @@ public class GuiceInjectOnFinalFieldTest {
   @Before
   public void setUp() {
     compilationHelper =
-        CompilationTestHelper.newInstance(new GuiceInjectOnFinalField(), getClass());
+        CompilationTestHelper.newInstance(GuiceInjectOnFinalField.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/GuiceOverridesGuiceInjectableMethodTest.java

@@ -33,7 +33,7 @@ public class GuiceOverridesGuiceInjectableMethodTest {
   @Before
   public void setUp() {
     compilationHelper =
-        CompilationTestHelper.newInstance(new GuiceOverridesGuiceInjectableMethod(), getClass());
+        CompilationTestHelper.newInstance(GuiceOverridesGuiceInjectableMethod.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/GuiceOverridesJavaxInjectableMethodTest.java

@@ -33,7 +33,7 @@ public class GuiceOverridesJavaxInjectableMethodTest {
   @Before
   public void setUp() {
     compilationHelper =
-        CompilationTestHelper.newInstance(new GuiceOverridesJavaxInjectableMethod(), getClass());
+        CompilationTestHelper.newInstance(GuiceOverridesJavaxInjectableMethod.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/IncompatibleModifiersCheckerTest.java

@@ -36,7 +36,7 @@ public class IncompatibleModifiersCheckerTest {
   @Before
   public void setUp() {
     compilationHelper = CompilationTestHelper
-        .newInstance(new IncompatibleModifiersChecker(), getClass())
+        .newInstance(IncompatibleModifiersChecker.class, getClass())
         .addSourceLines(
             "test/NotPrivateOrFinal.java",
             "package test;",

core/src/test/java/com/google/errorprone/bugpatterns/InjectAssistedInjectAndInjectOnConstructorsTest.java

@@ -35,7 +35,7 @@ public class InjectAssistedInjectAndInjectOnConstructorsTest {
   public void setUp() {
     compilationHelper =
         CompilationTestHelper.newInstance(
-            new InjectAssistedInjectAndInjectOnConstructors(), getClass());
+            InjectAssistedInjectAndInjectOnConstructors.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/InjectAssistedInjectAndInjectOnSameConstructorTest.java

@@ -35,7 +35,7 @@ public class InjectAssistedInjectAndInjectOnSameConstructorTest {
   public void setUp() {
     compilationHelper =
         CompilationTestHelper.newInstance(
-            new InjectAssistedInjectAndInjectOnSameConstructor(), getClass());
+            InjectAssistedInjectAndInjectOnSameConstructor.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/InjectInvalidTargetingOnScopingAnnotationTest.java

@@ -35,7 +35,7 @@ public class InjectInvalidTargetingOnScopingAnnotationTest {
   public void setUp() {
     compilationHelper =
         CompilationTestHelper.newInstance(
-            new InjectInvalidTargetingOnScopingAnnotation(), getClass());
+            InjectInvalidTargetingOnScopingAnnotation.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/InjectJavaxInjectOnAbstractMethodTest.java

@@ -34,7 +34,7 @@ public class InjectJavaxInjectOnAbstractMethodTest {
   @Before
   public void setUp() {
     compilationHelper =
-        CompilationTestHelper.newInstance(new InjectJavaxInjectOnAbstractMethod(), getClass());
+        CompilationTestHelper.newInstance(InjectJavaxInjectOnAbstractMethod.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/InjectJavaxInjectOnFinalFieldTest.java

@@ -33,7 +33,7 @@ public class InjectJavaxInjectOnFinalFieldTest {
   @Before
   public void setUp() {
     compilationHelper =
-        CompilationTestHelper.newInstance(new InjectJavaxInjectOnFinalField(), getClass());
+        CompilationTestHelper.newInstance(InjectJavaxInjectOnFinalField.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/InjectMoreThanOneInjectableConstructorTest.java

@@ -34,7 +34,7 @@ public class InjectMoreThanOneInjectableConstructorTest {
   @Before
   public void setUp() {
     compilationHelper =
-        CompilationTestHelper.newInstance(new InjectMoreThanOneInjectableConstructor(), getClass());
+        CompilationTestHelper.newInstance(InjectMoreThanOneInjectableConstructor.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/InjectMoreThanOneQualifierTest.java

@@ -34,7 +34,7 @@ public class InjectMoreThanOneQualifierTest {
   @Before
   public void setUp() {
     compilationHelper =
-        CompilationTestHelper.newInstance(new InjectMoreThanOneQualifier(), getClass());
+        CompilationTestHelper.newInstance(InjectMoreThanOneQualifier.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/InjectMoreThanOneScopeAnnotationOnClassTest.java

@@ -34,7 +34,7 @@ public class InjectMoreThanOneScopeAnnotationOnClassTest {
   public void setUp() {
     compilationHelper = 
         CompilationTestHelper.newInstance(
-            new InjectMoreThanOneScopeAnnotationOnClass(), getClass());
+            InjectMoreThanOneScopeAnnotationOnClass.class, getClass());
   }
 
   @Test

core/src/test/java/com/google/errorprone/bugpatterns/InjectOverlappingQualifierAndScopeAnnotationTest.java

@@ -35,7 +35,7 @@ public class InjectOverlappingQualifierAndScopeAnnotationTest {
   public void setUp() {
     compilationHelper =
         CompilationTestHelper.newInstance(
-            new InjectOverlappingQualifierAndScopeAnnotation(), getClass());
+            InjectOverlappingQualifierAndScopeAnnotation.class, getClass());
   }
 
   @Test