Automatic code cleanup.

PiperOrigin-RevId: 499956864

core/src/main/java/com/google/errorprone/bugpatterns/AlreadyChecked.java

@@ -50,6 +50,7 @@
 import java.util.Deque;
 import java.util.HashSet;
 import java.util.Set;
+import javax.inject.Inject;
 import org.checkerframework.checker.nullness.qual.Nullable;
 
 /** Bugpattern to find conditions which are checked more than once. */
@@ -58,6 +59,7 @@ public final class AlreadyChecked extends BugChecker implements CompilationUnitT
 
   private final ConstantExpressions constantExpressions;
 
+  @Inject
   public AlreadyChecked(ErrorProneFlags flags) {
     this.constantExpressions = ConstantExpressions.fromFlags(flags);
   }

core/src/main/java/com/google/errorprone/bugpatterns/AlwaysThrows.java

@@ -48,6 +48,7 @@
 import java.lang.reflect.InvocationTargetException;
 import java.util.UUID;
 import java.util.function.Consumer;
+import javax.inject.Inject;
 import org.checkerframework.checker.nullness.qual.Nullable;
 
 /** A {@link BugChecker}; see the associated {@link BugPattern} annotation for details. */
@@ -136,6 +137,7 @@ void validate(MethodInvocationTree tree, String argument) {
 
   private final ConstantExpressions constantExpressions;
 
+  @Inject
   public AlwaysThrows(ErrorProneFlags flags) {
     this.constantExpressions = ConstantExpressions.fromFlags(flags);
   }

core/src/main/java/com/google/errorprone/bugpatterns/BoxedPrimitiveEquality.java

@@ -31,6 +31,7 @@
 import com.sun.tools.javac.code.Symbol;
 import com.sun.tools.javac.code.Symbol.VarSymbol;
 import com.sun.tools.javac.code.Type;
+import javax.inject.Inject;
 
 /** A {@link BugChecker}; see the associated {@link BugPattern} annotation for details. */
 @BugPattern(
@@ -43,6 +44,7 @@
 public final class BoxedPrimitiveEquality extends AbstractReferenceEquality {
   private final boolean handleNumber;
 
+  @Inject
   public BoxedPrimitiveEquality(ErrorProneFlags flags) {
     this.handleNumber = flags.getBoolean("BoxedPrimitiveEquality:HandleNumber").orElse(true);
   }

core/src/main/java/com/google/errorprone/bugpatterns/CheckReturnValue.java

@@ -84,6 +84,7 @@
 import com.sun.tools.javac.processing.JavacProcessingEnvironment;
 import java.util.Optional;
 import java.util.stream.Stream;
+import javax.inject.Inject;
 import javax.lang.model.element.ElementKind;
 import org.checkerframework.checker.nullness.qual.Nullable;
 
@@ -139,6 +140,7 @@ public MethodKind getMethodKind(MethodSymbol method) {
   private final MessageTrailerStyle messageTrailerStyle;
   private final ResultUsePolicyEvaluator<VisitorState, Symbol, MethodSymbol> evaluator;
 
+  @Inject
   public CheckReturnValue(ErrorProneFlags flags) {
     super(flags);
     this.messageTrailerStyle =

core/src/main/java/com/google/errorprone/bugpatterns/DefaultCharset.java

@@ -70,6 +70,7 @@
 import java.util.Iterator;
 import java.util.List;
 import java.util.Scanner;
+import javax.inject.Inject;
 
 /** A {@link BugChecker}; see the associated {@link BugPattern} annotation for details. */
 @BugPattern(
@@ -200,6 +201,7 @@ String replacement() {
 
   private final boolean byteArrayOutputStreamToString;
 
+  @Inject
   public DefaultCharset(ErrorProneFlags flags) {
     this.byteArrayOutputStreamToString =
         flags.getBoolean("DefaultCharset:ByteArrayOutputStreamToString").orElse(true);

core/src/main/java/com/google/errorprone/bugpatterns/DoNotCallChecker.java

@@ -68,6 +68,7 @@
 import java.util.Map;
 import java.util.Optional;
 import java.util.stream.Stream;
+import javax.inject.Inject;
 import javax.lang.model.element.Modifier;
 
 /** A {@link BugChecker}; see the associated {@link BugPattern} annotation for details. */
@@ -77,6 +78,7 @@ public class DoNotCallChecker extends BugChecker
   private final boolean checkNewGetClassMethods;
   private final boolean checkThreadRun;
 
+  @Inject
   public DoNotCallChecker(ErrorProneFlags flags) {
     checkNewGetClassMethods =
         flags.getBoolean("DoNotCallChecker:CheckNewGetClassMethods").orElse(true);

core/src/main/java/com/google/errorprone/bugpatterns/EqualsIncompatibleType.java

@@ -44,6 +44,7 @@
 import com.sun.source.tree.MethodInvocationTree;
 import com.sun.source.tree.Tree;
 import com.sun.tools.javac.code.Type;
+import javax.inject.Inject;
 
 /**
  * @author avenet@google.com (Arnaud J. Venet)
@@ -66,6 +67,7 @@ public class EqualsIncompatibleType extends BugChecker
 
   private final TypeCompatibilityUtils typeCompatibilityUtils;
 
+  @Inject
   public EqualsIncompatibleType(ErrorProneFlags flags) {
     this.typeCompatibilityUtils = TypeCompatibilityUtils.fromFlags(flags);
   }

core/src/main/java/com/google/errorprone/bugpatterns/FieldCanBeStatic.java

@@ -61,6 +61,7 @@
 import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.regex.Pattern;
 import java.util.stream.Stream;
+import javax.inject.Inject;
 import javax.lang.model.element.NestingKind;
 
 /** Finds fields which can be safely made static. */
@@ -81,6 +82,7 @@ public final class FieldCanBeStatic extends BugChecker implements VariableTreeMa
   private final WellKnownMutability wellKnownMutability;
   private final ConstantExpressions constantExpressions;
 
+  @Inject
   public FieldCanBeStatic(ErrorProneFlags flags) {
     this.wellKnownMutability = WellKnownMutability.fromFlags(flags);
     this.constantExpressions = ConstantExpressions.fromFlags(flags);

core/src/main/java/com/google/errorprone/bugpatterns/IgnoredPureGetter.java

@@ -40,6 +40,7 @@
 import com.sun.tools.javac.code.Symbol.MethodSymbol;
 import com.sun.tools.javac.code.Type;
 import java.util.Optional;
+import javax.inject.Inject;
 
 /** Flags ignored return values from pure getters. */
 @BugPattern(
@@ -61,6 +62,7 @@ public IgnoredPureGetter() {
     this(ErrorProneFlags.empty());
   }
 
+  @Inject
   public IgnoredPureGetter(ErrorProneFlags flags) {
     super(flags);
   }

core/src/main/java/com/google/errorprone/bugpatterns/ImpossibleNullComparison.java

@@ -69,6 +69,7 @@
 import java.util.Optional;
 import java.util.Set;
 import javax.annotation.Nullable;
+import javax.inject.Inject;
 
 /** Matches comparison of proto fields to {@code null}. */
 @BugPattern(
@@ -145,6 +146,7 @@ private static boolean isNull(ExpressionTree tree) {
   private final boolean matchTestAssertions;
   private final boolean matchOptionalAndMultimap;
 
+  @Inject
   public ImpossibleNullComparison(ErrorProneFlags flags) {
     this.matchTestAssertions =
         flags.getBoolean("ProtoFieldNullComparison:MatchTestAssertions").orElse(true);

core/src/main/java/com/google/errorprone/bugpatterns/MethodCanBeStatic.java

@@ -54,6 +54,7 @@
 import java.util.HashSet;
 import java.util.Map;
 import java.util.Set;
+import javax.inject.Inject;
 import javax.lang.model.element.Modifier;
 
 /** A {@link BugChecker}; see the associated {@link BugPattern} annotation for details. */
@@ -65,6 +66,7 @@
 public class MethodCanBeStatic extends BugChecker implements CompilationUnitTreeMatcher {
   private final FindingOutputStyle findingOutputStyle;
 
+  @Inject
   public MethodCanBeStatic(ErrorProneFlags flags) {
     boolean findingPerSite = flags.getBoolean("MethodCanBeStatic:FindingPerSite").orElse(false);
     this.findingOutputStyle =

core/src/main/java/com/google/errorprone/bugpatterns/MissingOverride.java

@@ -30,6 +30,7 @@
 import com.google.errorprone.matchers.Description;
 import com.google.errorprone.util.ASTHelpers;
 import com.sun.source.tree.MethodTree;
+import javax.inject.Inject;
 import javax.lang.model.element.Modifier;
 
 /** A {@link BugChecker}; see the associated {@link BugPattern} annotation for details. */
@@ -42,6 +43,7 @@ public class MissingOverride extends BugChecker implements MethodTreeMatcher {
   /** if true, don't warn on missing {@code @Override} annotations inside interfaces */
   private final boolean ignoreInterfaceOverrides;
 
+  @Inject
   public MissingOverride(ErrorProneFlags flags) {
     this.ignoreInterfaceOverrides =
         flags.getBoolean("MissingOverride:IgnoreInterfaceOverrides").orElse(false);

core/src/main/java/com/google/errorprone/bugpatterns/OptionalNotPresent.java

@@ -42,6 +42,7 @@
 import com.sun.source.tree.Tree;
 import com.sun.tools.javac.code.Symbol.MethodSymbol;
 import java.util.stream.Stream;
+import javax.inject.Inject;
 
 /**
  * @author mariasam@google.com (Maria Sam)
@@ -59,6 +60,7 @@ public final class OptionalNotPresent extends BugChecker implements CompilationU
 
   private final ConstantExpressions constantExpressions;
 
+  @Inject
   public OptionalNotPresent(ErrorProneFlags flags) {
     this.constantExpressions = ConstantExpressions.fromFlags(flags);
   }

core/src/main/java/com/google/errorprone/bugpatterns/ParameterName.java

@@ -56,6 +56,7 @@
 import java.util.Optional;
 import java.util.function.Consumer;
 import java.util.regex.Matcher;
+import javax.inject.Inject;
 
 /** A {@link BugChecker}; see the associated {@link BugPattern} annotation for details. */
 @BugPattern(
@@ -68,6 +69,7 @@ public class ParameterName extends BugChecker
 
   private final ImmutableList<String> exemptPackages;
 
+  @Inject
   public ParameterName(ErrorProneFlags errorProneFlags) {
     this.exemptPackages =
         errorProneFlags

core/src/main/java/com/google/errorprone/bugpatterns/ReturnValueIgnored.java

@@ -47,6 +47,7 @@
 import com.sun.tools.javac.code.Symbol.MethodSymbol;
 import com.sun.tools.javac.code.Type;
 import java.util.regex.Pattern;
+import javax.inject.Inject;
 import javax.lang.model.element.Modifier;
 import javax.lang.model.element.Name;
 
@@ -419,6 +420,7 @@ public ReturnValueIgnored() {
     this.matcher = anyOf(ALL_MATCHERS);
   }
 
+  @Inject
   public ReturnValueIgnored(ErrorProneFlags flags) {
     super(flags);
     this.matcher = createMatcher(flags);

core/src/main/java/com/google/errorprone/bugpatterns/TooManyParameters.java

@@ -30,6 +30,7 @@
 import com.google.errorprone.bugpatterns.BugChecker.MethodTreeMatcher;
 import com.google.errorprone.matchers.Description;
 import com.sun.source.tree.MethodTree;
+import javax.inject.Inject;
 
 /** A {@link BugChecker}; see the associated {@link BugPattern} annotation for details. */
 @BugPattern(
@@ -60,6 +61,7 @@ public class TooManyParameters extends BugChecker implements MethodTreeMatcher {
 
   private final int limit;
 
+  @Inject
   public TooManyParameters(ErrorProneFlags flags) {
     this.limit = flags.getInteger(TOO_MANY_PARAMETERS_FLAG_NAME).orElse(DEFAULT_LIMIT);
     checkArgument(limit > 0, "%s (%s) must be > 0", TOO_MANY_PARAMETERS_FLAG_NAME, limit);

core/src/main/java/com/google/errorprone/bugpatterns/TreeToString.java

@@ -40,6 +40,7 @@
 import com.sun.tools.javac.code.Symbol.VarSymbol;
 import com.sun.tools.javac.code.Type;
 import java.util.Optional;
+import javax.inject.Inject;
 
 /**
  * Flags {@code com.sun.source.tree.Tree#toString} usage in {@link BugChecker}s.
@@ -67,6 +68,7 @@ public class TreeToString extends AbstractToString {
 
   private final boolean transitiveEnclosingBugchecker;
 
+  @Inject
   public TreeToString(ErrorProneFlags errorProneFlags) {
     this.transitiveEnclosingBugchecker =
         errorProneFlags.getBoolean("TreeToString:transitiveEnclosingBugchecker").orElse(true);

core/src/main/java/com/google/errorprone/bugpatterns/UngroupedOverloads.java

@@ -42,6 +42,7 @@
 import java.util.List;
 import java.util.Map;
 import java.util.stream.Stream;
+import javax.inject.Inject;
 import javax.lang.model.element.Name;
 
 /**
@@ -57,6 +58,7 @@ public class UngroupedOverloads extends BugChecker implements ClassTreeMatcher {
 
   private final Boolean batchFindings;
 
+  @Inject
   public UngroupedOverloads(ErrorProneFlags flags) {
     batchFindings = flags.getBoolean("UngroupedOverloads:BatchFindings").orElse(false);
   }

core/src/main/java/com/google/errorprone/bugpatterns/UnsynchronizedOverridesSynchronized.java

@@ -45,6 +45,7 @@
 import com.sun.tools.javac.code.Flags;
 import com.sun.tools.javac.code.Symbol.MethodSymbol;
 import com.sun.tools.javac.code.Type;
+import javax.inject.Inject;
 import javax.lang.model.element.Modifier;
 
 /** A {@link BugChecker}; see the associated {@link BugPattern} annotation for details. */
@@ -60,6 +61,7 @@ public UnsynchronizedOverridesSynchronized() {
     this(ErrorProneFlags.empty());
   }
 
+  @Inject
   public UnsynchronizedOverridesSynchronized(ErrorProneFlags flags) {
     this.constantExpressions = ConstantExpressions.fromFlags(flags);
   }

core/src/main/java/com/google/errorprone/bugpatterns/UnusedVariable.java

@@ -109,6 +109,7 @@
 import java.util.Set;
 import java.util.concurrent.atomic.AtomicBoolean;
 import javax.annotation.Nullable;
+import javax.inject.Inject;
 import javax.lang.model.element.ElementKind;
 import javax.lang.model.element.Modifier;
 import javax.lang.model.element.Name;
@@ -169,6 +170,7 @@ public final class UnusedVariable extends BugChecker implements CompilationUnitT
 
   private final boolean reportInjectedFields;
 
+  @Inject
   public UnusedVariable(ErrorProneFlags flags) {
     ImmutableSet.Builder<String> methodAnnotationsExemptingParameters =
         ImmutableSet.<String>builder().add("org.robolectric.annotation.Implementation");

core/src/main/java/com/google/errorprone/bugpatterns/WrongOneof.java

@@ -48,6 +48,7 @@
 import java.util.HashSet;
 import java.util.List;
 import java.util.Set;
+import javax.inject.Inject;
 
 /** Matches always-default expressions in oneof switches. */
 @BugPattern(
@@ -59,6 +60,7 @@ public final class WrongOneof extends BugChecker implements SwitchTreeMatcher {
 
   private final ConstantExpressions constantExpressions;
 
+  @Inject
   public WrongOneof(ErrorProneFlags flags) {
     this.constantExpressions = ConstantExpressions.fromFlags(flags);
   }

core/src/main/java/com/google/errorprone/bugpatterns/apidiff/AndroidJdkLibsChecker.java

@@ -30,6 +30,7 @@
 import com.sun.source.tree.ExpressionTree;
 import java.io.IOException;
 import java.io.UncheckedIOException;
+import javax.inject.Inject;
 
 /**
  * Checks for uses of classes, fields, or methods that are not compatible with legacy Android
@@ -63,6 +64,7 @@ private static ApiDiff loadApiDiff(boolean allowJava8) {
 
   private final boolean allowJava8;
 
+  @Inject
   public AndroidJdkLibsChecker(ErrorProneFlags flags) {
     this(flags.getBoolean("Android:Java8Libs").orElse(false));
   }

core/src/main/java/com/google/errorprone/bugpatterns/apidiff/Java8ApiChecker.java

@@ -29,6 +29,7 @@
 import java.io.UncheckedIOException;
 import java.util.Map;
 import java.util.regex.Pattern;
+import javax.inject.Inject;
 
 /** Checks for uses of classes, fields, or methods that are not compatible with JDK 8 */
 @BugPattern(
@@ -70,6 +71,7 @@ private static ApiDiff loadApiDiff(ErrorProneFlags errorProneFlags) {
 
   private static final String CHECKSUM = "java/util/zip/Checksum";
 
+  @Inject
   public Java8ApiChecker(ErrorProneFlags errorProneFlags) {
     super(loadApiDiff(errorProneFlags));
   }

core/src/main/java/com/google/errorprone/bugpatterns/collectionincompatibletype/CollectionIncompatibleType.java

@@ -40,6 +40,7 @@
 import java.util.Collection;
 import java.util.List;
 import java.util.Map;
+import javax.inject.Inject;
 
 /**
  * Checker for calling Object-accepting methods with types that don't match the type arguments of
@@ -73,6 +74,7 @@ private enum FixType {
   private final FixType fixType;
   private final TypeCompatibilityUtils typeCompatibilityUtils;
 
+  @Inject
   public CollectionIncompatibleType(ErrorProneFlags flags) {
     this.fixType =
         flags.getEnum("CollectionIncompatibleType:FixType", FixType.class).orElse(FixType.NONE);

core/src/main/java/com/google/errorprone/bugpatterns/collectionincompatibletype/IncompatibleArgumentType.java

@@ -46,6 +46,7 @@
 import java.util.List;
 import java.util.Map;
 import javax.annotation.Nullable;
+import javax.inject.Inject;
 import javax.lang.model.element.Parameterizable;
 import javax.lang.model.element.TypeParameterElement;
 
@@ -59,6 +60,7 @@ public class IncompatibleArgumentType extends BugChecker implements MethodInvoca
 
   private final TypeCompatibilityUtils typeCompatibilityUtils;
 
+  @Inject
   public IncompatibleArgumentType(ErrorProneFlags flags) {
     this.typeCompatibilityUtils = TypeCompatibilityUtils.fromFlags(flags);
   }