Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't report NonFinalStaticField findings for fields modified in @BeforeAll methods #4239

Closed
trask opened this issue Jan 4, 2024 · 0 comments
Closed

Don't report NonFinalStaticField findings for fields modified in @BeforeAll methods #4239

trask opened this issue Jan 4, 2024 · 0 comments

Comments

@trask
Copy link

trask commented Jan 4, 2024

Same as #4215, but for JUnit 5
hisener added a commit to DataDog/error-prone that referenced this issue Jan 11, 2024
@hisener
Do not report NonFinalStaticField findings for fields modified in `…
c0ce50c 
…@BeforeAll` methods

Resolves google#4239.
@hisener hisener mentioned this issue Jan 11, 2024
Closed
hisener added a commit to DataDog/error-prone that referenced this issue Jan 11, 2024
@hisener
Do not report NonFinalStaticField findings for fields modified in `…
8a109a8 
…@BeforeAll` methods

Resolves google#4239.
copybara-service bot pushed a commit that referenced this issue Jan 22, 2024
@hisener
Do not report NonFinalStaticField findings for fields modified in `…
812dc0a 
…@BeforeAll` methods

Analogous to #4215.

Resolves #4239.

Fixes #4251

FUTURE_COPYBARA_INTEGRATE_REVIEW=#4251 from DataDog:halil.sener/4239-non-final-static-field-junit-5-before-all 8a109a8
PiperOrigin-RevId: 597978105
@copybara-service copybara-service bot mentioned this issue Jan 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@trask