Update dagger version to 2.50 #4242
Assignees
Comments
copybara-service bot
pushed a commit
that referenced
this issue
Jan 5, 2024
Fixes #4242 PiperOrigin-RevId: 595979381
Merged
copybara-service bot
pushed a commit
that referenced
this issue
Jan 5, 2024
Prompted by #4242 (`mvn org.codehaus.mojo:versions-maven-plugin:2.16.2:{update-properties,use-latest-releases} -DgenerateBackupPoms=false -f third_party/java_src/error_prone/project/pom.xml -Dexcludes=org.hamcrest:hamcrest-core,org.hamcrest:hamcrest-library,com.google.inject.extensions:guice-assistedinject,com.google.inject.extensions:guice-servlet,com.google.inject.extensions:guice-testlib`. Without the exclusions, I got test errors. The Hamcrest ones might be related to API changes? The Guice ones might be related to getting out of sync with `guice.version`, which the `mvn` command does not update?) PiperOrigin-RevId: 595989581
Merged
copybara-service bot
pushed a commit
that referenced
this issue
Jan 5, 2024
Prompted by #4242 (`mvn org.codehaus.mojo:versions-maven-plugin:2.16.2:{update-properties,use-latest-releases} -DgenerateBackupPoms=false -f third_party/java_src/error_prone/project/pom.xml -Dexcludes=org.hamcrest:hamcrest-core,org.hamcrest:hamcrest-library,com.google.inject.extensions:guice-assistedinject,com.google.inject.extensions:guice-servlet,com.google.inject.extensions:guice-testlib`. Without the exclusions, I got test errors. The Hamcrest ones might be related to API changes? The Guice ones might be related to getting out of sync with `guice.version`, which the `mvn` command does not update?) PiperOrigin-RevId: 596010863
|
Thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This isn't really an
error-proneissue, it's an intellij issue where it incorrectly imports dependencies from test scope (and others) from maven: https://youtrack.jetbrains.com/issue/IDEA-264271/Maven-projects-with-annotationProcessorPaths-not-loaded-correctly-if-artifact-has-dependencies-in-test-scopeThey haven't fixed it for years, and since 2.50
daggerhas introduced some classes that are not in2.40.5...iferror-proneupdated to 2.50 it would make life simpler for those of us using intellij.The text was updated successfully, but these errors were encountered: