Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recognize java.time types as immutable #477

Closed
michaelhixson opened this issue Nov 15, 2016 · 2 comments
Closed

recognize java.time types as immutable #477

michaelhixson opened this issue Nov 15, 2016 · 2 comments

Comments

@michaelhixson
Copy link
Contributor

I see you have a whitelist for known-immutable types recognized by the @Immutable annotation / bug pattern. Would you consider adding the immutable java.time types to that list?

I have lots of types that should be @Immutable, but maybe half of them have a LocalDateTime or something similar that trips up error prone. I could add a bunch of @SuppressWarnings but it would be cool if I didn't have to.
@cushon
Copy link
Collaborator

cushon commented Nov 15, 2016

Would you consider adding the immutable java.time types to that list?

Definitely. Any interest in putting together a PR?

@michaelhixson
Copy link
Contributor Author

Will do.

@michaelhixson michaelhixson mentioned this issue Nov 15, 2016
Merged
cushon pushed a commit that referenced this issue Nov 15, 2016
@michaelhixson @cushon
Whitelist java.time interfaces whose contracts demand immutability (#478
b490b0c 
)

Also whitelist abstract classes with the same contract and whitelist the
implementations of those interfaces and abstract classes.

Fixes #477
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelhixson @cushon