Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WORKSPACE in Bazel example #1295

Closed
wants to merge 1 commit into from
Closed

Update WORKSPACE in Bazel example #1295

wants to merge 1 commit into from

Conversation

the1derer
Copy link

v2.3.4 is not available

v2.3.4 is not available
@tbroyer
Copy link
Contributor

tbroyer commented Jun 15, 2019

2.3.4 hasn't been released yet, but this is about 2.3.4-SNAPSHOT.
The problem here actually is that error_prone_ant no longer exists. AFAICT, it's been replaced with error_prone_core's with-dependencies variant (along with a few unbundled dependencies, due to license concerns)

@the1derer
Copy link
Author

@tbroyer
Thanks for the reply.
I actually first tried "error_prone_core-with-dependencies-2.3.4-SNAPSHOT"
But I was not able to find artifact-name for the same.
Can you provide the artifact-name that I can use for the "error_prone_core-with-dependencies-2.3.4-SNAPSHOT"?
Thanks.

@tbroyer
Copy link
Contributor

tbroyer commented Jun 16, 2019

Try with com.google.errorprone:error_prone_core:jar:with-dependencies:2.3.4-SNAPSHOT, or possibly com.google.errorprone:error_prone_core:2.3.4-SNAPSHOT:jar:with-dependencies.

That being said, it looks like this would eventually have to be moved to using the Skylark jvm_maven_import_external (see https://docs.bazel.build/versions/master/skylark/backward-compatibility.html#remove-native-maven-jar or bazelbuild/bazel#6799)

@the1derer the1derer closed this Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants