Don't additionally suggest var unused = ... or removing the statement for an assertThat(...) call with a missing isTrue() call.
#3845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…nt for an `assertThat(...)` call with a missing `isTrue()` call. `isTrue()` is essentially guaranteed to be correct, so the additional suggestion is just noise and an invitation to accidentally apply the wrong fix. PiperOrigin-RevId: 520035528
copybara-service
bot
force-pushed
the
test_520035528
branch
from
9eed554
to
ae1046c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't additionally suggest
var unused = ...or removing the statement for anassertThat(...)call with a missingisTrue()call.isTrue()is essentially guaranteed to be correct, so the additional suggestion is just noise and an invitation to accidentally apply the wrong fix.