Refactor comment handling in tokenization to use a new ErrorProneComment class that doesn't extend from javac's internal Comment #4407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_636203659
branch
2 times, most recently
from
3ae2144
to
cfc3f31
Compare
…ent class that doesn't extend from javac's internal Comment This is pre-work for handling upcoming JDK changes to the Comment API, which break the current subclass approach by changing the return type of `Comment#getPos`. This change encapsulates more of the internal javac APIs. PiperOrigin-RevId: 638438532
copybara-service
bot
force-pushed
the
test_636203659
branch
from
cfc3f31
to
c2df1b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor comment handling in tokenization to use a new ErrorProneComment class that doesn't extend from javac's internal Comment
This is pre-work for handling upcoming JDK changes to the Comment API, which break the current subclass approach by changing the return type of
Comment#getPos. This change encapsulates more of the internal javac APIs.