Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Markdown of links in README #607

Merged
merged 1 commit into from Apr 26, 2017
Merged

Fix Markdown of links in README #607

merged 1 commit into from Apr 26, 2017

Conversation

ejona86
Copy link
Contributor

@ejona86 ejona86 commented Apr 26, 2017

The []() and [][] styles of linking can't be separated by spaces/newline
on GitHub. I kept the []()-style for short URLs, but for long URLs that
caused line-wrapping issues I swapped to the [][] to make the text more
readable.

The []() and [][] styles of linking can't be separated by spaces/newline
on GitHub. I kept the []()-style for short URLs, but for long URLs that
caused line-wrapping issues I swapped to the [][] to make the text more
readable.
@ejona86
Copy link
Contributor Author

ejona86 commented Apr 26, 2017

:-/ It seems https://github.com/google/error-prone/wiki/For-Developers and https://github.com/google/error-prone/wiki/Writing-a-check are also broken and could use fixing.

https://github.com/google/error-prone/wiki/Writing-a-check also accidentally uses ````java (instead of ```java; 3 vs 4) prevents it from "closing" the code literal.

@nick-someone nick-someone merged commit 88a6bc6 into google:master Apr 26, 2017
@nick-someone
Copy link
Member

Thanks for the pointers! I've cleaned up the referenced pages.

@ejona86 ejona86 deleted the link-readme branch April 26, 2017 22:20
Stephan202 referenced this pull request Apr 28, 2017
Instead, use a TaskListener to apply the refactoring before the
compilation was about to end. This allows clients to depend on
implementation details of JavacTaskImpl if they want to do so.

Fixes #608

MOE_MIGRATED_REVID=154446890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants