-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated SQL-on-FHIR-v2 test results and updated tests #1032
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bashir2 for the changes. There are only few minor question/suggestions that I have raised, can you please have a look?
pipelines/common/src/test/java/com/google/fhir/analytics/view/SQLonFHIRv2Test.java
Outdated
Show resolved
Hide resolved
pipelines/common/src/test/resources/sql-on-fhir-v2-tests/fn_reference_keys.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chandrashekar-s for the review.
pipelines/common/src/test/java/com/google/fhir/analytics/view/SQLonFHIRv2Test.java
Outdated
Show resolved
Hide resolved
pipelines/common/src/test/resources/sql-on-fhir-v2-tests/fn_reference_keys.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the review comments @bashir2, the changes look good.
Description of what I changed
This is the preparation for adding our implementation to the SQL-on-FHIR v2 repo here. Please note this is on top of PR #1026 and only the last commit belongs to this PR.
E2E test
TESTED:
Ran the tests and inspected the generated
sql-on-fhir-v2-test-result.json
.Checklist: I completed these to help reviewers :)
I have read and will follow the review process.
I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
I ran
mvn clean package
right before creating this pull request and added all formatting changes to my commit.All new and existing tests passed.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master