Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated SQL-on-FHIR-v2 test results and updated tests #1032

Merged
merged 11 commits into from
Apr 25, 2024

Conversation

bashir2
Copy link
Collaborator

@bashir2 bashir2 commented Apr 24, 2024

Description of what I changed

This is the preparation for adding our implementation to the SQL-on-FHIR v2 repo here. Please note this is on top of PR #1026 and only the last commit belongs to this PR.

E2E test

TESTED:

Ran the tests and inspected the generated sql-on-fhir-v2-test-result.json.

Checklist: I completed these to help reviewers :)

  • I have read and will follow the review process.

  • I am familiar with Google Style Guides for the language I have coded in.

    No? Please take some time and review Java and Python style guides.

  • My IDE is configured to follow the Google code styles.

    No? Unsure? -> configure your IDE.

  • I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

  • I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

  • All new and existing tests passed.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 50.47%. Comparing base (b32c490) to head (b277f1f).

Files Patch % Lines
...java/com/cerner/bunsen/ProfileMappingProvider.java 28.57% 3 Missing and 2 partials ⚠️
...r/bunsen/avro/tools/GenerateAggregatedSchemas.java 0.00% 4 Missing ⚠️
...a/com/cerner/bunsen/ProfileMapperFhirContexts.java 66.66% 2 Missing ⚠️
...c/main/java/com/google/fhir/analytics/FhirEtl.java 0.00% 2 Missing ⚠️
.../java/com/google/fhir/analytics/ParquetMerger.java 0.00% 2 Missing ⚠️
...java/com/google/fhir/analytics/DataProperties.java 66.66% 2 Missing ⚠️
...ava/com/google/fhir/analytics/PipelineManager.java 50.00% 2 Missing ⚠️
.../com/google/fhir/analytics/AvroConversionUtil.java 87.50% 0 Missing and 1 partial ⚠️
...ava/com/google/fhir/analytics/view/ViewSchema.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1032      +/-   ##
============================================
+ Coverage     50.33%   50.47%   +0.13%     
+ Complexity      665      663       -2     
============================================
  Files            91       91              
  Lines          5487     5472      -15     
  Branches        704      702       -2     
============================================
  Hits           2762     2762              
+ Misses         2465     2452      -13     
+ Partials        260      258       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@chandrashekar-s chandrashekar-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bashir2 for the changes. There are only few minor question/suggestions that I have raised, can you please have a look?

Copy link
Collaborator Author

@bashir2 bashir2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chandrashekar-s for the review.

Copy link
Collaborator

@chandrashekar-s chandrashekar-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the review comments @bashir2, the changes look good.

@bashir2 bashir2 merged commit e80dd24 into google:master Apr 25, 2024
6 checks passed
@bashir2 bashir2 deleted the refId2-SoFv2 branch April 25, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants