-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the schema doc #1087
Added the schema doc #1087
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1087 +/- ##
============================================
- Coverage 50.49% 50.44% -0.06%
+ Complexity 674 673 -1
============================================
Files 91 91
Lines 5519 5519
Branches 709 709
============================================
- Hits 2787 2784 -3
- Misses 2470 2473 +3
Partials 262 262 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bashir2 for documenting this, this could be a very good reference for the FHIR-Parquet mapping. I had an initial look at it and have shared my comments. They all are minor. But I will have a one more look at it tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chandrashekar-s for the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bashir2 for the changes again, the details looks good. For the example that you had asked for multiple extensions scenario, I don't have the example handy (Will update on this later). You can merge this PR in the meanwhile I guess.
Description of what I changed
This is the first step for addressing #1025.
E2E test
TESTED:
NA
Checklist: I completed these to help reviewers :)
I have read and will follow the review process.
I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
I ran
mvn clean package
right before creating this pull request and added all formatting changes to my commit.All new and existing tests passed.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master