Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the schema doc #1087

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Added the schema doc #1087

merged 3 commits into from
Jun 10, 2024

Conversation

bashir2
Copy link
Collaborator

@bashir2 bashir2 commented Jun 5, 2024

Description of what I changed

This is the first step for addressing #1025.

E2E test

TESTED:

NA

Checklist: I completed these to help reviewers :)

  • I have read and will follow the review process.

  • I am familiar with Google Style Guides for the language I have coded in.

    No? Please take some time and review Java and Python style guides.

  • My IDE is configured to follow the Google code styles.

    No? Unsure? -> configure your IDE.

  • I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

  • I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

  • All new and existing tests passed.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.44%. Comparing base (05cf4fb) to head (d448d4b).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1087      +/-   ##
============================================
- Coverage     50.49%   50.44%   -0.06%     
+ Complexity      674      673       -1     
============================================
  Files            91       91              
  Lines          5519     5519              
  Branches        709      709              
============================================
- Hits           2787     2784       -3     
- Misses         2470     2473       +3     
  Partials        262      262              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@chandrashekar-s chandrashekar-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bashir2 for documenting this, this could be a very good reference for the FHIR-Parquet mapping. I had an initial look at it and have shared my comments. They all are minor. But I will have a one more look at it tomorrow.

doc/schema.md Show resolved Hide resolved
doc/schema.md Show resolved Hide resolved
doc/schema.md Show resolved Hide resolved
Copy link
Collaborator Author

@bashir2 bashir2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chandrashekar-s for the review.

doc/schema.md Show resolved Hide resolved
doc/schema.md Show resolved Hide resolved
doc/schema.md Show resolved Hide resolved
Copy link
Collaborator

@chandrashekar-s chandrashekar-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bashir2 for the changes again, the details looks good. For the example that you had asked for multiple extensions scenario, I don't have the example handy (Will update on this later). You can merge this PR in the meanwhile I guess.

doc/schema.md Show resolved Hide resolved
doc/schema.md Show resolved Hide resolved
@bashir2 bashir2 merged commit ee4e6e2 into google:master Jun 10, 2024
6 checks passed
@bashir2 bashir2 deleted the schemaDoc branch June 10, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants