Add user name and password to controller config #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
bashir2
reviewed
Jul 31, 2023
pipelines/batch/src/main/java/org/openmrs/analytics/FhirSearchUtil.java
Outdated
Show resolved
Hide resolved
pipelines/batch/src/main/java/org/openmrs/analytics/FhirSearchUtil.java
Outdated
Show resolved
Hide resolved
|
/gcbrun |
LJNIC
force-pushed
the
feature/add-more-configs-to-controller
branch
from
1df05c1
to
4bf754a
Compare
|
I fixed the issues, we just had a wrong push. |
bashir2
reviewed
Aug 11, 2023
There was a problem hiding this comment.
Thanks for the update; a couple of minor points:
- Please familiarize yourself with the review process. In particular, please use the PR description template and fill out the
TESTEDfield. Please make sure that you indicate you have tested setting username/password through the controller. - Please sign Google's CLA; you should be able to do that by following the "Details" link of the
cla/googlecheck that is currently failing (from PR's main page).
pipelines/controller/src/main/java/org/openmrs/analytics/DataProperties.java
Outdated
Show resolved
Hide resolved
michealharrington
force-pushed
the
feature/add-more-configs-to-controller
branch
from
f336a1b
to
0129012
Compare
michealharrington
force-pushed
the
feature/add-more-configs-to-controller
branch
from
0129012
to
1277553
Compare
|
This should be good to final review and merging. |
bashir2
approved these changes
Aug 18, 2023
bashir2
reviewed
Aug 18, 2023
| fhirdata.numOfDwhSnapshotsToRetain=3 | ||
| fhirdata.fhirServerPassword=Admin123 | ||
| fhirdata.fhirServerUserName=Admin |
There was a problem hiding this comment.
Note to myself: We should update the default/example configs like this application.yaml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Added user name and password to the controller configuration for better FHIR search support. Fixes #677.
E2E test
TESTED:
Added the
fhirServerPasswordandfhirServerUserNameproperties to the controllerapplication.yamland ensured the properties were set and fetching to a FHIR server worked.Checklist: I completed these to help reviewers :)
I have read and will follow the review process.
I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
I ran
mvn clean packageright before creating this pull request and added all formatting changes to my commit.All new and existing tests passed.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master