Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaces the spinner GIF with CSS #953

Merged
merged 4 commits into from Feb 21, 2024
Merged

replaces the spinner GIF with CSS #953

merged 4 commits into from Feb 21, 2024

Conversation

bashir2
Copy link
Collaborator

@bashir2 bashir2 commented Feb 16, 2024

Description of what I changed

Fixes #420

Measuring approximate CPU usage (the controller UI was on a remote machine, connected through Chrome Remote Desktop; these are based on CPU usage on the local machine):

  • Before the change, i.e., with the animated gif, CPU usage increased by 15-20% while showing index.html.
  • After the change, i.e., with the CSS version, CPU usage increased by ~3%. while showing index.html.

E2E test

TESTED:

Ran the controller locally, also checked the static index.html with spinners turned on and the CPU usage
was much lower than the old animated GIF.

Checklist: I completed these to help reviewers :)

  • I have read and will follow the review process.

  • I am familiar with Google Style Guides for the language I have coded in.

    No? Please take some time and review Java and Python style guides.

  • My IDE is configured to follow the Google code styles.

    No? Unsure? -> configure your IDE.

  • I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

  • I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

  • All new and existing tests passed.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

Copy link
Collaborator

@chandrashekar-s chandrashekar-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bashir2 for the changes, they look fine.

@chandrashekar-s
Copy link
Collaborator

@bashir2 Can you also please add the difference in the CPU utilization in the description?

Copy link
Collaborator Author

@bashir2 bashir2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @chandrashekar-s

@bashir2
Copy link
Collaborator Author

bashir2 commented Feb 20, 2024

@bashir2 Can you also please add the difference in the CPU utilization in the description?

Updated PR description with CPU usage changes.

@bashir2 bashir2 merged commit 97fa93d into google:master Feb 21, 2024
5 checks passed
@bashir2 bashir2 deleted the spinner branch March 4, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update controller UI and replace the spinner.
2 participants