Allow request mutation by Access checkers #140
Conversation
There was a problem hiding this comment.
I have defined an interface on how we can support request mutation.
@bashir2 patl.
This is not complete. Sending it for initial review of the interface.
We also wanted to support updating query params for search by POST.
This is currently not supported - #87,
Should we still support this for search query updates now or just add this as an AI to the above bug ?
There was a problem hiding this comment.
Thanks @vivekmittal07 for the suggested interface. I think this is generally fine, I have just made some minor suggestions.
server/src/main/java/com/google/fhir/gateway/interfaces/AccessDecision.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/google/fhir/gateway/BearerAuthorizationInterceptor.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/google/fhir/gateway/interfaces/AccessDecision.java
Show resolved
Hide resolved
server/src/main/java/com/google/fhir/gateway/BearerAuthorizationInterceptor.java
Outdated
Show resolved
Hide resolved
Just replied on #87; I think search by POST works for HAPI. |
vivekmittal07
force-pushed
the
request-mutation
branch
from
c2fa4c3
to
31de3f4
Compare
vivekmittal07
changed the title
There was a problem hiding this comment.
Thanks @vivekmittal07 for the changes. I just asked for reverting the static change; please feel free to merge this after addressing that.
server/src/main/java/com/google/fhir/gateway/BearerAuthorizationInterceptor.java
Outdated
Show resolved
Hide resolved
…gle FHIR Gateway repo (#29) * Allow request mutation by Access checkers (google#140) * Define access decision preprocess stage to mutate the request params * Documentation for request mutation change. Added test cases. * Removed static identifier from request mutation method * Updated the scan paths for demo app to load the core beans (google#132) Add default scan paths in the exec application * Support gzip encoding in data transfer (google#147) * supporting gzip for client and server data transfer * Version change for the next dev cycle (google#159) * Fix in unit test * Fixed unimplemented method in the OpenSRPSyncAccessDecision --------- Co-authored-by: vivekmittal07 <105198504+vivekmittal07@users.noreply.github.com> Co-authored-by: anchita-g <109063673+anchita-g@users.noreply.github.com> Co-authored-by: Bashir Sadjad <bashir@google.com>
Description of what I changed
Add request mutation capability in AccessDecision
#122
E2E test
TESTED:
Verified using unit test on request mutation.
Checklist: I completed these to help reviewers :)
I have read and will follow the review process.
I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
I ran
mvn clean packageright before creating this pull request and added all formatting changes to my commit.All new and existing tests passed.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master