Refactorings for supporting custom endpoints with examples. #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashir2
force-pushed
the
custom
branch
2 times, most recently
from
09ffc9f
to
71708a1
Compare
bashir2
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
exec/src/main/java/com/google/fhir/gateway/CustomGenericEndpointExample.java
Show resolved
Hide resolved
anchita-g
approved these changes
Aug 18, 2023
exec/src/main/java/com/google/fhir/gateway/CustomFhirEndpointExample.java
Show resolved
Hide resolved
bashir2
commented
Aug 18, 2023
exec/src/main/java/com/google/fhir/gateway/CustomFhirEndpointExample.java
Show resolved
Hide resolved
exec/src/main/java/com/google/fhir/gateway/CustomGenericEndpointExample.java
Show resolved
Hide resolved
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Fixes #139.
This shows examples of how to support custom endpoints. To do this some refactoring of the
servercode isdone. Also now the default servlet handles requests to
/fhir/*instead of/*.E2E test
TESTED:
Ran the server locally and tested the custom endpoints.
The current unit-tests needs to be updated before review.
Checklist: I completed these to help reviewers :)
I have read and will follow the review process.
I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
I ran
mvn clean packageright before creating this pull request and added all formatting changes to my commit.All new and existing tests passed.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master