Skip to content

Commit

Permalink
Don't rely on Java8 to invoke sdkmanager (#6809)
Browse files Browse the repository at this point in the history
  • Loading branch information
romainguy committed May 16, 2023
1 parent f6c8ce1 commit 2ade177
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions build/android/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,7 @@ FILAMENT_NDK_VERSION=${FILAMENT_NDK_VERSION:-$(cat `dirname $0`/ndk.version)}

# Install the required NDK version specifically (if not present)
if [[ ! -d "${ANDROID_HOME}/ndk/$FILAMENT_NDK_VERSION" ]]; then
# NOTE: We MUST use Java 1.8 to run sdkmanager currently, it fails starting with Java 11
JAVA_HOME=${JAVA_HOME_8_X64} ${ANDROID_HOME}/tools/bin/sdkmanager "ndk;$FILAMENT_NDK_VERSION" > /dev/null
${ANDROID_HOME}/cmdline-tools/latest/bin/sdkmanager "ndk;$FILAMENT_NDK_VERSION" > /dev/null
fi

# Only build 1 64 bit target during presubmit to cut down build times during presubmit
Expand Down

0 comments on commit 2ade177

Please sign in to comment.