Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmgen should support tiled EXR images #176

Closed
prideout opened this issue Aug 28, 2018 · 4 comments · Fixed by #198
Closed

cmgen should support tiled EXR images #176

prideout opened this issue Aug 28, 2018 · 4 comments · Fixed by #198
Labels
enhancement New feature or request tools Issue/feature request related to tools

Comments

@prideout
Copy link
Contributor

We need to either (a) contribute a high-level utility function to tinyexr, or (b) write or own tile assembler.

For inspiration here is a tiled-to-scanline converter:
https://github.com/syoyo/tinyexr/blob/b9f100e4a9ab80389b151fc2b53731d31035d327/test_tinyexr.cc#L75

See also:
syoyo/tinyexr#93

@romainguy romainguy added enhancement New feature or request tools Issue/feature request related to tools labels Aug 28, 2018
prideout added a commit that referenced this issue Aug 28, 2018
prideout added a commit that referenced this issue Aug 28, 2018
@prideout
Copy link
Contributor Author

prideout commented Sep 4, 2018

Now that we've updated tinyexr which now handles tiled images, this issue should be trivial to close (just remove an assert)

#197

@romainguy
Copy link
Collaborator

Should I just remove the assert then? I preserved it just in case.

@romainguy
Copy link
Collaborator

I just checked and TinyEXR does support tiled images in the function we call now.

@prideout
Copy link
Contributor Author

prideout commented Sep 4, 2018

Correct, we can simply remove the assert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tools Issue/feature request related to tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants