We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug Mistake in the Jacobian of transform between distributions (missing a reciprocal)
Maybe a terminology problem ?
To Reproduce Steps to reproduce the behavior:
Screenshots
Expected behavior Eq.126 :
Eq.127:
Additional context some references:
[1] Physically Based Rendering, Third Edition 13.5.1
[2] Microfacet Models for Refraction through Rough Surfaces, EGSR 2007
Jacobian of transformation from l->h is shown, h->l should be the reciprocal
The text was updated successfully, but these errors were encountered:
also in 5.3.4.2.2 "Discrete Domain", the pdf is missing a "4"
Sorry, something went wrong.
Thanks, those look like omissions/typos indeed.
fix typos in documentation
822a583
Fixes #6294
bc40ff7
4c45d42
Fixes google#6294
pixelflinger
Successfully merging a pull request may close this issue.
Describe the bug
Mistake in the Jacobian of transform between distributions (missing a reciprocal)
Maybe a terminology problem ?
To Reproduce
Steps to reproduce the behavior:
Screenshots
![image](https://user-images.githubusercontent.com/25838728/201461901-8775a549-2ee5-44b1-b9c8-f631a9336055.png)
Expected behavior
![image](https://user-images.githubusercontent.com/25838728/201461295-3f2550cf-5b07-4f13-aed4-13c449451262.png)
Eq.126 :
Eq.127:
![image](https://user-images.githubusercontent.com/25838728/201461648-e3c5e242-522c-4db8-a020-3f8103e59809.png)
Additional context
some references:
[1] Physically Based Rendering, Third Edition 13.5.1
![image](https://user-images.githubusercontent.com/25838728/201461228-8690542b-77c4-4988-a7a5-34f9eed51e90.png)
[2] Microfacet Models for Refraction through Rough Surfaces, EGSR 2007
Jacobian of transformation from l->h is shown, h->l should be the reciprocal
The text was updated successfully, but these errors were encountered: