sample-gltf-viewer: introduce QR code feature. #3599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me get this straight: you also created a project called |
Well it's just the name of a Kotlin class, it seemed like the most appropriate name at the time. :) |
bejado
reviewed
Mar 1, 2021
| @@ -74,6 +111,126 @@ class MainActivity : Activity() { | |||
| modelViewer.view.bloomOptions = bloomOptions | |||
| } | |||
|
|
|||
| private fun bindPreview(cameraProvider: ProcessCameraProvider) { | |||
| val preview : Preview = Preview.Builder().build().also { | |||
There was a problem hiding this comment.
I think you can leave off the : Preview here and : CameraSelector down below
| val scanner = BarcodeScanning.getClient(options) | ||
| scanner.process(image) | ||
| .addOnSuccessListener { barcodes -> | ||
| for (barcode in barcodes) { |
There was a problem hiding this comment.
If multiple barcodes are detected, does it make sense to call downloadFromBarcode for each? Perhaps we just want to download the first one we find.
There was a problem hiding this comment.
Good catch, I will simplify this.
bejado
approved these changes
Mar 1, 2021
This commit did not require any changes to ModelViewer or any of our libraries. It involved the following additions to the app MainActivity: - Add a button to the app bar, which requires AppCompatActivity as per https://developer.android.com/training/appbar/setting-up - Add a PreviewView widget from androidx. - Add usage of BarcodeScanner in mlkit. - Add a coroutine for downloading data via HttpURLConnection. We would like to add more features in the future, including the ability to drop additional models without rescanning and the ability to drop zip files.
prideout
added a commit
that referenced
this pull request
Mar 2, 2021
This adds a button to the action bar and spins up a WebSockets server. Unlike my first attempt (#3599), this does not use a piping server and is therefore much faster to use over a LAN.
prideout
added a commit
that referenced
this pull request
Mar 3, 2021
This adds a WebSockets server to filament-utils-android. Unlike my first attempt (#3599), this does not use a piping server and is therefore much faster to use over a LAN. It also has lower user friction because there is no need to touch a button in the app or scan a QR code.
prideout
added a commit
that referenced
this pull request
Mar 3, 2021
This adds a WebSockets server to filament-utils-android. Unlike my first attempt (#3599), this does not use a piping server and is therefore much faster to use over a LAN. It also has lower user friction because there is no need to touch a button in the app or scan a QR code.
prideout
added a commit
that referenced
this pull request
Mar 3, 2021
This adds a WebSockets server to filament-utils-android. Unlike my first attempt (#3599), this does not use a piping server and is therefore much faster to use over a LAN. It also has lower user friction because there is no need to touch a button in the app or scan a QR code.
prideout
added a commit
that referenced
this pull request
Mar 3, 2021
This adds a WebSockets server to filament-utils-android. Unlike my first attempt (#3599), this does not use a piping server and is therefore much faster to use over a LAN. It also has lower user friction because there is no need to touch a button in the app or scan a QR code.
prideout
added a commit
that referenced
this pull request
Mar 3, 2021
This adds a WebSockets server to filament-utils-android. Unlike my first attempt (#3599), this does not use a piping server and is therefore much faster to use over a LAN. It also has lower user friction because there is no need to touch a button in the app or scan a QR code.
prideout
added a commit
that referenced
this pull request
Mar 3, 2021
This adds a WebSockets server to filament-utils-android. Unlike my first attempt (#3599), this does not use a piping server and is therefore much faster to use over a LAN. It also has lower user friction because there is no need to touch a button in the app or scan a QR code.
AdrianAtGoogle
pushed a commit
to AdrianAtGoogle/filament
that referenced
this pull request
Mar 22, 2021
This adds a WebSockets server to filament-utils-android. Unlike my first attempt (google#3599), this does not use a piping server and is therefore much faster to use over a LAN. It also has lower user friction because there is no need to touch a button in the app or scan a QR code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works in tandem with the new page at https://google.github.io/filament/qrcode/
This feature did not require any changes to
ModelViewer.ktor any of our libraries. It involves the following additions to the app MainActivity:Add a button to the app bar, which requires AppCompatActivity as per
https://developer.android.com/training/appbar/setting-up
Add a PreviewView widget from androidx.
Add usage of BarcodeScanner in mlkit.
Add a coroutine for downloading data via HttpURLConnection.
We would like to add more features in the future, including the ability
to drop additional models without rescanning and the ability to drop
zip files.
This feature was inspired by a Model Viewer editor feature, thanks @elalish