fix install android debug samples apk error. #7230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzp1984
force-pushed
the
fix/install-android-samples-cp-error
branch
from
8a8d723
to
95133b9
Compare
romainguy
requested changes
Oct 4, 2023
suzp1984
force-pushed
the
fix/install-android-samples-cp-error
branch
from
95133b9
to
1633c9a
Compare
suzp1984
force-pushed
the
fix/install-android-samples-cp-error
branch
from
1633c9a
to
23ab49f
Compare
pixelflinger
force-pushed
the
fix/install-android-samples-cp-error
branch
from
23ab49f
to
d7ec69c
Compare
pixelflinger
approved these changes
Oct 26, 2023
suzp1984
force-pushed
the
fix/install-android-samples-cp-error
branch
from
d7ec69c
to
9edc650
Compare
|
I notice this problem still exist. |
romainguy
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cp not exist debug sample apk.
./build.sh -p android -k sample-gltf-viewer -i debugTake
sample-gltf-vieweras an example, above cmd will result in :cp: samples/sample-gltf-viewer/build/outputs/apk/debug/sample-gltf-viewer-debug-unsigned.apk: No such file or directoryThe root cause is that the
androidwill signed thedebugapk with~/.android/debug.keystore, which is the default generated by android gradle plugin globally.remove unsigned tag from release apk don't make sense
[Cause] the unsigned apk will not installed on the android, the apk must be signed anyway. So I think remove the
unsignedkeyword don't make sense, at lease let people know, it's an unsigned apk.