vk: Fix unsupported depth blitting #7789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On certain hardware (pixel 4 for example), blitting of depth texture is not supported as an "optimalTilingFeature". In these cases, we'd would need to do a shader-based blit. We - Add the shader blit in PostProcessingManager - Add a driver API to check for support for blitting depthStencil attachments. - Fix some debugging ifdefs in vk backend. The validation fixed is: `[ VUID-vkCmdBlitImage-dstImage-02000 ] Object 0: handle = 0xb400007c300701d0, type = VK_OBJECT_TYPE_COMMAND_BUFFER; Object 1: handle = 0xf2039b0000000771, type = VK_OBJECT_TYPE_IMAGE; | MessageID = 0x86bc2a78 | In vkCmdBlitImage, VkFormatFeatureFlags (0x1c601) does not support required feature VK_FORMAT_FEATURE_2_BLIT_DST_BIT for format 126 used by VkImage 0xf2039b0000000771[] with tiling VK_IMAGE_TILING_OPTIMAL. The Vulkan spec states: The format features of dstImage must contain VK_FORMAT_FEATURE_BLIT_DST_BIT`
pixelflinger
requested changes
Apr 23, 2024
| @@ -303,6 +303,7 @@ DECL_DRIVER_API_SYNCHRONOUS_0(bool, isProtectedContentSupported) | |||
| DECL_DRIVER_API_SYNCHRONOUS_N(bool, isStereoSupported, backend::StereoscopicType, stereoscopicType) | |||
| DECL_DRIVER_API_SYNCHRONOUS_0(bool, isParallelShaderCompileSupported) | |||
| DECL_DRIVER_API_SYNCHRONOUS_0(bool, isDepthStencilResolveSupported) | |||
| DECL_DRIVER_API_SYNCHRONOUS_N(bool, isDepthStencilBlitSupported, backend::TextureFormat, format) | |||
There was a problem hiding this comment.
so depth blitting support is not all or nothing? it depends on the specific format?
There was a problem hiding this comment.
In practice, it's probably all or nothing.
But in Vulkan, for the general use case of "can you do x with texture", it's a check against the format of the texture.
pixelflinger
approved these changes
Apr 24, 2024
poweifeng
force-pushed
the
pf/shader-depth-blit
branch
from
d283fbe
to
c9ed363
Compare
bejado
reviewed
Apr 24, 2024
| } | ||
| } | ||
| format = (VkFormat) (1 + (int) format); | ||
| if (format == VK_FORMAT_ASTC_12x12_SRGB_BLOCK) { |
There was a problem hiding this comment.
Maybe comment that this is the last format provided by VK_VERSION_1_0? And do we want to exclude VK_FORMAT_ASTC_12x12_SRGB_BLOCK from this check (maybe this if needs to be before line 539)?
There was a problem hiding this comment.
yeah, this could definitely be cleaner. I'll put up a follow-up to clean this up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On certain hardware (pixel 4 for example), blitting of depth texture is not supported as an "optimalTilingFeature". In these cases, we'd would need to do a shader-based blit. We
The validation fixed is:
[ VUID-vkCmdBlitImage-dstImage-02000 ] Object 0: handle = 0xb400007c300701d0, type = VK_OBJECT_TYPE_COMMAND_BUFFER; Object 1: handle = 0xf2039b0000000771, type = VK_OBJECT_TYPE_IMAGE; | MessageID = 0x86bc2a78 | In vkCmdBlitImage, VkFormatFeatureFlags (0x1c601) does not support required feature VK_FORMAT_FEATURE_2_BLIT_DST_BIT for format 126 used by VkImage 0xf2039b0000000771[] with tiling VK_IMAGE_TILING_OPTIMAL. The Vulkan spec states: The format features of dstImage must contain VK_FORMAT_FEATURE_BLIT_DST_BIT