Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests that fail because of slash directions #115

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Add tests that fail because of slash directions #115

merged 1 commit into from
Sep 5, 2018

Conversation

DanTup
Copy link
Contributor

@DanTup DanTup commented Sep 5, 2018

Failing tests due to #112.

I couldn't figure out how to mark them as failing (or skip) since there's no @failingTest and the test function seems custom.

@tvolkert

@DanTup DanTup mentioned this pull request Sep 5, 2018
Open
tvolkert
tvolkert approved these changes Sep 5, 2018
View reviewed changes
Copy link
Collaborator

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Don't worry about the failures - we'll fix them before cutting a new release.

Thanks!

@tvolkert tvolkert merged commit 7ef7e0c into google:master Sep 5, 2018
@DanTup DanTup deleted the add-failing-tests branch September 5, 2018 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvolkert tvolkert tvolkert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DanTup @tvolkert