Fix runtime errors in recording_test #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84
There were a number of runtime failures. Some were simple. The ones that involved noSuchMethod in☹️
recording_proxy_mixin.dartwere not simple. Basically, because of how thenoSuchMethodis implemented, in terms of Futures and Streams, and how FutureReference.value and StreamReference.value work, types were being lost. Ifvaluewas aFuture<Directory>, as returned byFunction.apply, thenresultwas inevitablyFuture<dynamic>by the end ofnoSuchMethod.Tested with
dart --preview-dart-2 test/recording_test.dartanddart test/recording_test.dart.